Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 1.2.5 #350

Merged
merged 14 commits into from
Mar 15, 2023
Merged

release: 1.2.5 #350

merged 14 commits into from
Mar 15, 2023

Conversation

ajansari95
Copy link
Contributor

@ajansari95 ajansari95 commented Mar 15, 2023

1. Summary

Fixes QCK-172 QCK-173 QCK-174 QCK-175

2.Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

3. Implementation details

  • Updates inflation params and epoch provisions
  • Backport GovReopenChannel and GovCloseChannel
  • Post 1.2.5 upgrade handles pending delegations on regen-1

app/upgrades.go Outdated Show resolved Hide resolved
app/upgrades.go Outdated Show resolved Hide resolved
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of issues in the upgrade handler.

@ajansari95 ajansari95 changed the title Ajansari95/v1.2.5 Release: 1.2.5 Mar 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Merging #350 (2325f84) into release/v1.2.5 (08236aa) will decrease coverage by 0.19%.
The diff coverage is 14.38%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/v1.2.5     #350      +/-   ##
==================================================
- Coverage           53.41%   53.22%   -0.19%     
==================================================
  Files                 148      148              
  Lines               11367    11505     +138     
==================================================
+ Hits                 6072     6124      +52     
- Misses               4883     4968      +85     
- Partials              412      413       +1     
Flag Coverage Δ
unittests 53.22% <14.38%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/interchainstaking/client/cli/tx.go 10.73% <0.00%> (-1.17%) ⬇️
x/interchainstaking/keeper/keeper.go 72.58% <0.00%> (-0.32%) ⬇️
x/interchainstaking/keeper/msg_server.go 66.66% <0.00%> (-18.56%) ⬇️
x/interchainstaking/types/codec.go 38.70% <0.00%> (-2.67%) ⬇️
x/interchainstaking/types/msgs.go 63.79% <0.00%> (-10.21%) ⬇️
x/interchainstaking/keeper/abci.go 27.86% <6.25%> (-9.09%) ⬇️
app/upgrades.go 57.89% <100.00%> (+21.05%) ⬆️

... and 2 files with indirect coverage changes

@ajansari95 ajansari95 changed the base branch from release/v1.2.5-beta.0 to release/v1.2.5 March 15, 2023 11:53
@ajansari95
Copy link
Contributor Author

closes #349

@ajansari95 ajansari95 closed this Mar 15, 2023
@ajansari95 ajansari95 reopened this Mar 15, 2023
Copy link

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just add some tests - otherwise lgtm

app/upgrades.go Show resolved Hide resolved
x/interchainstaking/keeper/abci.go Outdated Show resolved Hide resolved
@aljo242 aljo242 changed the title Release: 1.2.5 release: 1.2.5 Mar 15, 2023
app/upgrades.go Outdated Show resolved Hide resolved
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joe-bowman
Copy link
Contributor

Changelog please!

@ajansari95 ajansari95 merged commit 5656ca2 into release/v1.2.5 Mar 15, 2023
@ajansari95 ajansari95 deleted the ajansari95/v1.2.5 branch March 15, 2023 14:10
@faddat faddat mentioned this pull request May 8, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants