-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 1.2.5 #350
release: 1.2.5 #350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of issues in the upgrade handler.
Codecov Report
@@ Coverage Diff @@
## release/v1.2.5 #350 +/- ##
==================================================
- Coverage 53.41% 53.22% -0.19%
==================================================
Files 148 148
Lines 11367 11505 +138
==================================================
+ Hits 6072 6124 +52
- Misses 4883 4968 +85
- Partials 412 413 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
a01544e
to
84aa85a
Compare
closes #349 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's just add some tests - otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changelog please! |
1. Summary
Fixes QCK-172 QCK-173 QCK-174 QCK-175
2.Type of change
Please delete options that are not relevant.
3. Implementation details
GovReopenChannel
andGovCloseChannel
regen-1