backport: gov reopen/close to v1.2.5
#349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 14, 2023 16:26
joe-bowman
reviewed
Mar 15, 2023
| @@ -588,14 +589,17 @@ func (s *KeeperTestSuite) TestHandleRewardsCallbackEmptyResponse() { | |||
|
|
|||
| respbz, err := app.AppCodec().Marshal(&response) | |||
| s.Require().NoError(err) | |||
|
|
|||
| epoch := app.EpochsKeeper.GetEpochInfo(ctx, "epoch") | |||
| fmt.Println(epoch) | |||
joe-bowman
reviewed
Mar 15, 2023
x/interchainstaking/keeper/keeper.go
Outdated
| @@ -634,3 +639,7 @@ func DetermineAllocationsForRebalancing(currentAllocations map[string]math.Int, | |||
|
|
|||
| return out | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
If we are adding setEpochsKeeper, do we need to remove epochkeeper from NewKeeper (I added in v1.2.5)
There was a problem hiding this comment.
Yeah we should remove. We need to use setEpochsKeeper to ensure the order of keeper init is valid
joe-bowman
reviewed
Mar 15, 2023
| func (k msgServer) GovReopenChannel(goCtx context.Context, msg *types.MsgGovReopenChannel) (*types.MsgGovReopenChannelResponse, error) { | ||
| ctx := sdk.UnwrapSDKContext(goCtx) | ||
|
|
||
| // checking msg authority is the gov module address |
There was a problem hiding this comment.
This is no longer a proposal, so can remove these commented lines
joe-bowman
requested changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Fixes QCK-174
Backport
GovReopenChannelandGovCloseChannelAdd
InterchainStakingKeeper.SetEpochsKeeper()to prevent a panicNote: we should add test for the
msg_serverfunctionality in the future.