Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v1.1.0 #272

Merged
merged 20 commits into from
Jan 2, 2023
Merged

Release/v1.1.0 #272

merged 20 commits into from
Jan 2, 2023

Conversation

joe-bowman
Copy link
Contributor

@joe-bowman joe-bowman commented Dec 30, 2022

Release v1.1.0

  • add ics escrow module account to fix issue with locked up qAssets not being burnable post-redemption
  • fixes situation where zero weight intents can exist if weight for given intent is zero
  • remove burn permission from pr and mint module accounts
  • remove pre v1.0.0 upgrade handlers
  • add verbose errors for redelegation and unbonding tx failures
  • direct poolincentives to airdrop module account
  • replace redemption rate hard cap with soft cap
  • add chain restart migration to remove cosmoshub-4, close channels and burn minted qAtoms

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Merging #272 (b5e3c09) into main (4be1a23) will increase coverage by 1.13%.
The diff coverage is 61.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
+ Coverage   51.67%   52.81%   +1.13%     
==========================================
  Files         148      149       +1     
  Lines       11423    11244     -179     
==========================================
+ Hits         5903     5938      +35     
+ Misses       5139     4929     -210     
+ Partials      381      377       -4     
Flag Coverage Δ
unittests 52.81% <61.20%> (+1.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/app.go 83.30% <ø> (ø)
x/interchainstaking/keeper/msg_server.go 85.21% <0.00%> (ø)
x/interchainstaking/types/keys.go 48.14% <ø> (ø)
x/interchainstaking/keeper/abci.go 34.00% <20.00%> (-1.56%) ⬇️
x/interchainstaking/keeper/keeper.go 69.90% <21.42%> (+0.95%) ⬆️
x/interchainstaking/keeper/ibc_packet_handlers.go 19.01% <31.57%> (-0.05%) ⬇️
x/interchainstaking/keeper/intent.go 73.28% <54.54%> (-3.48%) ⬇️
x/interchainstaking/keeper/v1_1_upgrade_handler.go 82.75% <82.75%> (ø)
x/interchainstaking/keeper/hooks.go 70.65% <83.33%> (+0.53%) ⬆️
app/upgrades.go 57.89% <100.00%> (+47.56%) ⬆️
... and 4 more

ajansari95
ajansari95 previously approved these changes Jan 2, 2023
Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a NIT, otherwise LGTM

Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a performance improvement note... as this may be a good time for such a simple enhancement.

x/interchainstaking/keeper/intent.go Show resolved Hide resolved
@joe-bowman joe-bowman merged commit 4180101 into main Jan 2, 2023
@joe-bowman joe-bowman deleted the release/v1.1.0 branch January 2, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants