Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajansari95/escrow module account #265

Merged
merged 4 commits into from
Dec 19, 2022

Conversation

ajansari95
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Merging #265 (cea8a49) into release/v1.1.0 (ca8718f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/v1.1.0     #265      +/-   ##
==================================================
- Coverage           51.67%   51.66%   -0.01%     
==================================================
  Files                 148      148              
  Lines               11423    11425       +2     
==================================================
  Hits                 5903     5903              
- Misses               5139     5140       +1     
- Partials              381      382       +1     
Flag Coverage Δ
unittests 51.66% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/app.go 83.30% <ø> (ø)
x/interchainstaking/keeper/ibc_packet_handlers.go 19.05% <0.00%> (ø)
x/interchainstaking/keeper/keeper.go 68.63% <0.00%> (-0.32%) ⬇️
x/interchainstaking/keeper/msg_server.go 85.21% <0.00%> (ø)
x/interchainstaking/types/keys.go 48.14% <ø> (ø)

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but can you rebase on main please, so we don't get the Dockerfile changes in the PR.

(I think this may have been based on v1.0.0).

@ajansari95
Copy link
Contributor Author

lgtm, but can you rebase on main please, so we don't get the Dockerfile changes in the PR.

(I think this may have been based on v1.0.0).

the release v1.1.0 is one commit behind master will rebase release branch

@joe-bowman
Copy link
Contributor

Oh yes it probably is that. Thank you!

@ajansari95 ajansari95 merged commit 3441f0f into release/v1.1.0 Dec 19, 2022
@joe-bowman joe-bowman deleted the ajansari95/escrowModuleAccount branch December 19, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants