Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated rule in .golangci.yml #1533

Merged
merged 4 commits into from
May 2, 2024
Merged

Fix deprecated rule in .golangci.yml #1533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d8a1e3
fix deprecated config
pysel May 1, 2024
df41e87
Merge branch 'main' into fix-deprecated-golangci-config
faddat May 1, 2024
b87b158
Merge branch 'main' into fix-deprecated-golangci-config
faddat May 1, 2024
2a3d16e
fix workflow
pysel May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
# Require: The version of golangci-lint to use.
# When `install-mode` is `binary` (default) the value can be v1.2 or v1.2.3 or `latest` to use the latest version.
# When `install-mode` is `goinstall` the value can be v1.2.3, `latest`, or the hash of a commit.
version: v1.56.1
version: v1.57.2
args: --timeout 15m
# Optional: working directory, useful for monorepos
# working-directory: somedir
Expand Down
4 changes: 2 additions & 2 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ run:
tests: true
# # timeout for analysis, e.g. 30s, 5m, default is 1m
timeout: 10m
skip-dirs:
- third-party-chains
Comment on lines -5 to -6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

WARN [config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

ruslanakhtariev@169-231-72-96 quicksilver % golangci-lint version                         
golangci-lint has version 1.57.2 built with go1.22.1 from 77a8601a on 2024-03-28T19:01:11Z


linters:
disable-all: true
Expand Down Expand Up @@ -43,6 +41,8 @@ issues:

max-issues-per-linter: 10000
max-same-issues: 10000
exclude-dirs:
- third-party-chains

linters-settings:
gci:
Expand Down
Loading