Fix deprecated rule in .golangci.yml

[pysel]

1. Summary

Fixes #None

2.Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

• Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

[vercel]

@pysel is attempting to deploy a commit to the quicksilver Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The update in the .golangci.yml configuration file involves reconfiguring linting directories, specifically moving third-party-chains from skip-dirs to exclude-dirs. This adjustment enhances how linting rules are applied to project directories.

Changes

File	Change Summary
.golangci.yml	Moved third-party-chains from skip-dirs to exclude-dirs

🐰✨
A leap and a bound, the linter's tune resounds,
From skip to exclude, the chains are unbound.
No more in the shadows of skipping's flight,
Safe in exclusion, code shines bright!
🌟🐇

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4d8a1e3 and 2a3d16e.

Files selected for processing (1)

• .github/workflows/golangci.yml (1 hunks)

Files skipped from review due to trivial changes (1)

• .github/workflows/golangci.yml

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pysel]

WARN [config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`. 

[pysel]

ruslanakhtariev@169-231-72-96 quicksilver % golangci-lint version                         
golangci-lint has version 1.57.2 built with go1.22.1 from 77a8601a on 2024-03-28T19:01:11Z

[faddat]

Hey, it seems that this has strangely angered the winter. Could you check out what the issue is?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.91%. Comparing base (9b4b2b9) to head (2a3d16e).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1533   +/-   ##
=======================================
  Coverage   62.91%   62.91%           
=======================================
  Files         194      194           
  Lines       13632    13632           
=======================================
  Hits         8577     8577           
  Misses       4233     4233           
  Partials      822      822           

Flag	Coverage Δ
unittests	62.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[joe-bowman]

lgtm

failing lint

[joe-bowman]

@pysel I believe the issue here is that .github/workflows/golangci.yaml is using 1.56 not 1.57 and the setting while valid for your local instance, is not valid for the CI. Updating the CI version to 1.57.2 should do the trick, thank you!