Refactoring, insb. ensure_package_and_question_state_exist
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbritz
approved these changes
Aug 26, 2024
MHajoha
force-pushed
the
refactor-decorator
branch
from
3f71c8e to
fa6096e
Compare
MHajoha
force-pushed
the
static-files
branch
from
96b0bf7 to
2c9d3ba
Compare
# Conflicts: # questionpy_server/api/routes/_packages.py # questionpy_server/package.py # questionpy_server/web.py
� Conflicts: � questionpy_server/factories/package.py � questionpy_server/package.py � tests/questionpy_server/web/routes/test_packages.py
MHajoha
force-pushed
the
refactor-decorator
branch
from
fa6096e to
d35f2db
Compare
MartinGauk
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basiert auf #114.
Ich habe
ensure_package_and_question_state_existinensure_package,ensure_question_stateundensure_main_bodyauseinandergezogen. Da viele Routes alle drei benutzen wollen, gibt esensure_required_parts, der die kleineren drei Decorator applied, je nach dem, welche Parameter die Handler-Funktion hat.Außerdem habe ich die Web-spezifischen Sachen in
questionpy_server.webgeschoben und das meiste privat gemacht.Und ich habe
questionpy_server.worker.workernachquestionpy_server.worker.implgeschoben sowie das Interface (Worker) nachquestionpy_server.worker.__init__.