Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct redirect for code-server #3410

Conversation

benz0li
Copy link
Contributor

@benz0li benz0li commented Nov 21, 2022

Description

Closes #3352

Checklist

I have (if applicable):

  • filed a contributor agreement.
  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog

@cscheid
Copy link
Collaborator

cscheid commented Nov 21, 2022

@benz0li Thanks for the contribution!

@cscheid cscheid merged commit 20f61d3 into quarto-dev:main Nov 21, 2022
benz0li added a commit to b-data/jupyterlab-r-docker-stack that referenced this pull request Dec 21, 2022
benz0li added a commit to b-data/jupyterlab-python-docker-stack that referenced this pull request Dec 21, 2022
benz0li added a commit to b-data/jupyterlab-julia-docker-stack that referenced this pull request Dec 21, 2022
benz0li added a commit to b-data/julia-docker-stack that referenced this pull request Dec 21, 2022
benz0li added a commit to b-data/python-docker-stack that referenced this pull request Dec 21, 2022
benz0li added a commit to b-data/r-docker-stack that referenced this pull request Dec 21, 2022
@benz0li
Copy link
Contributor Author

benz0li commented Jan 6, 2023

@cscheid Unfortunately, this has not been backported to v1.2 and is therefore missing in v1.2.280.

@cscheid
Copy link
Collaborator

cscheid commented Jan 6, 2023

@benz0li We tend to be very conservative about backports (because they're included on other Posit products), so that was very likely by design.

@jjallaire Should we consider a backport of this one?

@jjallaire
Copy link
Collaborator

Our plan was certainly to backport it (in fact it's worth another check to make sure we didn't!). If we haven't backported it we should

@cscheid
Copy link
Collaborator

cscheid commented Jan 6, 2023

@jjallaire ok, great. I missed that. I'll check and put together a backport PR today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render PDF: 'Open in Browser' opens wrong link (code-server with Jupyter Server Proxy)
3 participants