Render PDF: 'Open in Browser' opens wrong link (code-server with Jupyter Server Proxy)

[benz0li]

Bug description

'Open in Browser' opens https://coder.jupyter.b-data.ch/hub/proxy/7095/web/viewer.html, which is wrong.

---

Browse at shows https://coder.jupyter.b-data.ch/user/benz0li/code-server/proxy/7095/web/viewer.html, which is correct.

---

@jjallaire @cscheid @dragonstyle May be reproduced at https://coder.jupyter.b-data.ch with image R (jupyterlab/r/verse:latest-devtools) using

---
title: "ggplot2 demo"
author: "Norah Jones"
date: "5/22/2021"
format: 
  html:
    code-fold: true
    fig-format: svg
---

## Air Quality

@fig-airquality further explores the impact of temperature on ozone level.

```{r}
#| label: fig-airquality
#| fig-cap: Temperature and ozone level.
#| warning: false

library(ggplot2)

ggplot(airquality, aes(Temp, Ozone)) + 
  geom_point() + 
  geom_smooth(method = "loess"
)
```

Checklist

• Please include a minimal, fully reproducible example in a single .qmd file? Please provide the whole file rather than the snippet you believe is causing the issue.
• Please format your issue so it is easier for us to read the bug report.
• Please document the RStudio IDE version you're running (if applicable), by providing the value displayed in the "About RStudio" main menu dialog?
• Please document the operating system you're running. If on Linux, please provide the specific distribution.

[benz0li]

R (jupyterlab/r/verse:latest-devtools) is based on debian:11 and has a patched version of Quarto 1.2.269 installed.

[benz0li]

ℹ️ The link for 'Open in Browser' is only wrong for 'Render PDF'. For 'Render DOCX' and 'Render HTML' the link is correct.

Please consider this issue for a patch release of v1.2.

[cscheid]

Thanks for the report!

I don't know if we ever supported Jupyter Server Proxy in vs-code. Is this a regression?

[benz0li]

Is this a regression?

No.

[benz0li]

'Open in Browser' for 'Render DOCX' and 'Render HTML' work out of the box.

I am quite sure, that the 'Open in Browser' URL for 'Render PDF' is being tampered with somewhere.

[jjallaire]

That popup isn't one that we are creating (that's VS Code / Code Server detecting a port). I think difference is that PDFs are hosted inside a special viewer URL whereas DOCX and HTML are hosted at the main root URL. Note that we do redirect from the main URL to the special viewer URL.

[benz0li]

Note that we do redirect from the main URL to the special viewer URL.

I will check where the 'special viewer URL' is created and add a special handling for isVSCodeTerminal() && isVSCodeServer().