Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove test for @ManagedBean #7

Merged
merged 2 commits into from
Apr 26, 2024
Merged

remove test for @ManagedBean #7

merged 2 commits into from
Apr 26, 2024

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Apr 26, 2024

  1. The @ManagedBean annotation is removed in Jakarta Annotations 3.0.
  2. This test was already disabled anyway.

Ladicek added 2 commits April 26, 2024 09:42
@Ladicek
add .idea to .gitignore
ab0955c
@Ladicek
remove test for @ManagedBean
79de3bb 
1. The `@ManagedBean` annotation is removed in Jakarta Annotations 3.0.
2. This test was already disabled anyway.
geoand
geoand approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand merged commit c8b7402 into quarkusio:main Apr 26, 2024
@Ladicek Ladicek mentioned this pull request Apr 26, 2024
Merged
@Ladicek Ladicek deleted the remove-managed-bean-test branch April 26, 2024 07:54
@geoand
Copy link
Contributor

geoand commented Apr 26, 2024

BTW, for Quarkus to pick this up, you'll need to do an update, see this for more details.

@Ladicek
Copy link
Contributor Author

Ladicek commented Apr 26, 2024

Thanks!

@geoand
Copy link
Contributor

geoand commented Apr 26, 2024

🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ladicek @geoand