ArC: implement CDI 4.1 #40208

Ladicek · 2024-04-23T09:38:24Z

No description provided.

Ladicek · 2024-04-23T09:38:54Z

Each commit is best reviewed separately. They are all fairly small, except of the one that adds support for method invokers.

gsmet · 2024-04-23T09:49:13Z

Not a review but nice work :).

github-actions · 2024-04-23T10:02:14Z

🙈 The PR is closed and the preview is expired.

Ladicek · 2024-04-24T09:16:57Z

Rebased.

independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/BeanManagerImpl.java

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanGenerator.java

mkouba

@Ladicek do you plan to add support for Quarkus build items used to define method invokers?

Ladicek · 2024-04-24T11:34:38Z

I don't think that's necessary. Method invokers can be registered in the bean registration phase, for which a build item already exists. (Aside: maybe this should be better documented?) I have a few examples (@Scheduled, @ConsumeEvent, Reactive Messaging) that I hope to submit after this is merged and I didn't need any new build items.

independent-projects/arc/runtime/src/main/java/io/quarkus/arc/ArcInvocationContext.java

independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/Types.java

mkouba · 2024-04-24T12:32:44Z

I don't think that's necessary. Method invokers can be registered in the bean registration phase, for which a build item already exists. (Aside: maybe this should be better documented?) I have a few examples (@Scheduled, @ConsumeEvent, Reactive Messaging) that I hope to submit after this is merged and I didn't need any new build items.

With BeanRegistrar#getInvokerFactory() you mean? Yes, that's hidden very well :-). OTOH we also have SyntheticBeanBuildItem and BeanRegistrar.RegistrationContext#configure() but I'm not sure if a dedicated build item would bring any benefit here...

Ladicek · 2024-04-24T12:54:40Z

With BeanRegistrar#getInvokerFactory() you mean? Yes, that's hidden very well :-)

Indeed that's what I meant :-) Yeah, I agree. I should probably write some documentation into the CDI integration guide...

Ladicek · 2024-04-26T07:54:03Z

Here's a PR to remove the test for @ManagedBean from the RESTEasy Reactive TCK: quarkusio/resteasy-reactive-testsuite#7 Will update this PR after that one is merged.

…s to 3.0.0

A producer may have priority as defined by CDI 4.1 (or obtained from a stereotype, as permitted but not really specified in CDI 4.0), but does not necessarily have to be an alternative. During ambiguity resolution, if such non-alternative producer with priority is declared on an alternative bean, we must first consider the priority declared on the producer, even if the producer is not itself an alternative. To do that, this commit changes the ambiguity resolution implementation to use `BeanInfo.getPririty()` instead of `getAlternativePriority()`. The difference is that `getAlternativePriority()` returns `null` when the bean itself is not an alternative. Given that the method was previously only used during ambiguity resolution, and only after non-alternative beans (and producers on non-alternative beans) were eliminated, this is correct. In fact, this commit also marks `BeanInfo.getAlternativePriority()` as deprecated for removal. For all practical purposes, `getPriority()` is a better choice; it is usually meaningless to consider a bean priority only when the bean is an alternative, and pretend that the bean has no priority when it is not an alternative.

…der with CurrentInjectionPointProvider

…) now

The new version doesn't contain the `@ManagedBean` annotation, which was removed in Jakarta Annotations 3.0.

Ladicek · 2024-04-26T08:12:42Z

Rebased and updated the RESTEasy Reactive TCK.

quarkus-bot · 2024-04-26T08:47:08Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit 944008f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2024-04-26T14:42:18Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 944008f.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✔️	JVM Tests - JDK 17			Logs	Raw logs	🔍
✔️	JVM Tests - JDK 21			Logs	Raw logs	🔍
✖	JVM Tests - JDK 17 Windows	`Build`	⚠️ Check →	Logs	Raw logs	🚧

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/maven

✖ io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratch - History

Cannot delete directory: target\test-classes\projects\project-generation - java.lang.RuntimeException

java.lang.RuntimeException: Cannot delete directory: target\test-classes\projects\project-generation
	at io.quarkus.maven.it.MojoTestBase.initEmptyProject(MojoTestBase.java:72)
	at io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratch(CreateProjectMojoIT.java:60)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.apache.commons.io.IOExceptionList: 1 exception(s): [org.apache.commons.io.IOIndexedException: IOException #0: Cannot delete file: target\test-classes\projects\project-generation\build-create-project-generation.log]
	at org.apache.commons.io.IOExceptionList.checkEmpty(IOExceptionList.java:50)

✖ io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratch - History

Cannot delete directory: target\test-classes\projects\project-generation - java.lang.RuntimeException

java.lang.RuntimeException: Cannot delete directory: target\test-classes\projects\project-generation
	at io.quarkus.maven.it.MojoTestBase.initEmptyProject(MojoTestBase.java:72)
	at io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratch(CreateProjectMojoIT.java:60)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.apache.commons.io.IOExceptionList: 1 exception(s): [org.apache.commons.io.IOIndexedException: IOException #0: Cannot delete file: target\test-classes\projects\project-generation\build-create-project-generation.log]
	at org.apache.commons.io.IOExceptionList.checkEmpty(IOExceptionList.java:50)

gsmet · 2024-04-26T14:45:57Z

@mkouba @manovotn all good for you? CI looks happy. I let you merge if you are :).

Ladicek requested review from mkouba and manovotn April 23, 2024 09:38

This comment has been minimized.

Sign in to view

manovotn mentioned this pull request Apr 24, 2024

Bump version.cdi-tck from 4.0.13 to 4.1.0 #40233

Closed

Ladicek force-pushed the arc-cdi-4.1 branch from 4743ee6 to b6a199f Compare April 24, 2024 09:16

This comment has been minimized.

Sign in to view

mkouba reviewed Apr 24, 2024

View reviewed changes

independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/BeanManagerImpl.java Outdated Show resolved Hide resolved

Ladicek force-pushed the arc-cdi-4.1 branch from b6a199f to 61c4715 Compare April 24, 2024 10:51

mkouba reviewed Apr 24, 2024

View reviewed changes

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanGenerator.java Outdated Show resolved Hide resolved

Ladicek force-pushed the arc-cdi-4.1 branch from 61c4715 to a8d09a7 Compare April 24, 2024 11:18

mkouba approved these changes Apr 24, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

manovotn reviewed Apr 24, 2024

View reviewed changes

independent-projects/arc/runtime/src/main/java/io/quarkus/arc/ArcInvocationContext.java Show resolved Hide resolved

independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/Types.java Outdated Show resolved Hide resolved

Ladicek force-pushed the arc-cdi-4.1 branch from a8d09a7 to ab7f5fe Compare April 24, 2024 12:50

This comment has been minimized.

Sign in to view

gastaldi mentioned this pull request Apr 25, 2024

Bump jakarta.annotation:jakarta.annotation-api from 2.1.1 to 3.0.0 #40279

Closed

This comment has been minimized.

Sign in to view

Ladicek added 17 commits April 26, 2024 09:57

ArC: update CDI to 4.1.0, Interceptors to 2.2.0 and Common Annotation…

2d8f7fd

…s to 3.0.0

ArC: implement the CreationalContexts TCK SPI

39c1aed

ArC: implement the Contextuals TCK SPI

fe9a1f8

ArC: prefer InvocationContext.getInterceptorBindings()

ae7c503

ArC: implement BeanContainer.getContexts()

51d6521

ArC: support registering multiple custom contexts for single scope

68bb910

ArC: implement BeanContainer.isMatchingBean() and isMatchingEvent()

71a5aea

ArC: improve validation of built-in beans injection

c168bd4

ArC: centralize code generation for wrapping InjectableReferenceProvi…

bc516b4

…der with CurrentInjectionPointProvider

ArC: fix CustomNormalScopeTest, we can use BeanContainer.getContexts(…

832a756

…) now

ArC: add support for method invokers

d93a237

ArC: remove extra test/java17 directory, now that Java 17 is the minimum

5cd5952

ArC: update documentation to CDI 4.1

ed93157

ArC: fix running the CDI TCK

890ed6a

Update TestNG to 7.8.0, a version used in the MicroProfile parent POM

3927cbd

Update the RESTEasy Reactive TCK

944008f

The new version doesn't contain the `@ManagedBean` annotation, which was removed in Jakarta Annotations 3.0.

Ladicek force-pushed the arc-cdi-4.1 branch from b8e8686 to 944008f Compare April 26, 2024 08:12

manovotn merged commit b77999a into quarkusio:main Apr 26, 2024
53 of 54 checks passed

quarkus-bot bot added this to the 3.11 - main milestone Apr 26, 2024

Ladicek deleted the arc-cdi-4.1 branch April 29, 2024 06:34

manovotn mentioned this pull request May 3, 2024

Getting annotation on intercepted static method returns null #40399

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ArC: implement CDI 4.1 #40208

ArC: implement CDI 4.1 #40208

Ladicek commented Apr 23, 2024

Ladicek commented Apr 23, 2024

gsmet commented Apr 23, 2024

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Apr 23, 2024 •

edited

Loading

Ladicek commented Apr 24, 2024

This comment has been minimized.

mkouba left a comment

Ladicek commented Apr 24, 2024

This comment has been minimized.

mkouba commented Apr 24, 2024

Ladicek commented Apr 24, 2024

This comment has been minimized.

This comment has been minimized.

Ladicek commented Apr 26, 2024

Ladicek commented Apr 26, 2024

quarkus-bot bot commented Apr 26, 2024

quarkus-bot bot commented Apr 26, 2024 •

edited by github-actions bot

Loading

gsmet commented Apr 26, 2024

ArC: implement CDI 4.1 #40208

ArC: implement CDI 4.1 #40208

Conversation

Ladicek commented Apr 23, 2024

Ladicek commented Apr 23, 2024

gsmet commented Apr 23, 2024

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Apr 23, 2024 • edited Loading

Ladicek commented Apr 24, 2024

This comment has been minimized.

mkouba left a comment

Choose a reason for hiding this comment

Ladicek commented Apr 24, 2024

This comment has been minimized.

mkouba commented Apr 24, 2024

Ladicek commented Apr 24, 2024

This comment has been minimized.

This comment has been minimized.

Ladicek commented Apr 26, 2024

Ladicek commented Apr 26, 2024

quarkus-bot bot commented Apr 26, 2024

Status for workflow Quarkus Documentation CI

quarkus-bot bot commented Apr 26, 2024 • edited by github-actions bot Loading

Status for workflow Quarkus CI

Failing Jobs

Flaky tests - Develocity

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/maven

gsmet commented Apr 26, 2024

github-actions bot commented Apr 23, 2024 •

edited

Loading

Status for workflow `Quarkus Documentation CI`

quarkus-bot bot commented Apr 26, 2024 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`