Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article about the size increase of binaries when using Mandrel 23.1 #1827

Merged

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Nov 6, 2023

Follow up to #1818

The article was written in a Jupyter notebook and exported to markdown using:

jupyter nbconvert index.ipynb --to markdown --NbConvertApp.output_files_dir=.

I tried converting it to asciidoc with:

jupyter nbconvert index.ipynb --to asciidoc --NbConvertApp.output_files_dir=.

but the output was not good. Same with pandoc conversion using:

pandoc -t asciidoc -f markdown index.md -o _posts/index.adoc

so I leave it as markdown.

@zakkak zakkak requested review from galderz and maxandersen November 6, 2023 14:44
Copy link

github-actions bot commented Nov 6, 2023

🙈 The PR is closed and the preview is expired.

Copy link

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Nice blog post!

_posts/2023-11-08-mandrel-23-1-image-size-increase.md Outdated Show resolved Hide resolved
_posts/2023-11-08-mandrel-23-1-image-size-increase.md Outdated Show resolved Hide resolved
_posts/2023-11-08-mandrel-23-1-image-size-increase.md Outdated Show resolved Hide resolved
@zakkak zakkak force-pushed the 2023-11-03-mandrel-23-1-image-size-increase branch from cf48068 to c0a1671 Compare November 8, 2023 12:33
@zakkak
Copy link
Contributor Author

zakkak commented Nov 8, 2023

Thanks you @jerboaa. I addressed your comments.

@gsmet gsmet merged commit 05a77b4 into quarkusio:develop Nov 8, 2023
1 check passed
@zakkak zakkak deleted the 2023-11-03-mandrel-23-1-image-size-increase branch November 8, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants