Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article about the size increase of binaries when using Mandrel 23.0 #1818

Merged

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Oct 19, 2023

The article was written in a Jupyter notebook and exported to markdown using:

jupyter nbconvert quarkus-size-22-3-23-0.ipynb --to markdown --NbConvertApp.output_files_dir=.

I tried converting it to asciidoc with:

jupyter nbconvert quarkus-size-22-3-23-0.ipynb --to asciidoc --NbConvertApp.output_files_dir=.

but the output was not good. Same with pandoc conversion using:

pandoc -t asciidoc -f markdown quarkus-size-22-3-23-0.md -o _posts/2023-10-26-mandrel-23-0-image-size-increase.adoc

so I leave it as markdown.

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

🙈 The PR is closed and the preview is expired.

@zakkak zakkak force-pushed the 2023-10-19-mandrel-23-0-image-size-increase branch from 94776d2 to f4439f7 Compare October 19, 2023 11:26
@zakkak zakkak marked this pull request as draft October 19, 2023 12:24
@zakkak zakkak marked this pull request as ready for review October 19, 2023 12:24
@zakkak zakkak force-pushed the 2023-10-19-mandrel-23-0-image-size-increase branch 2 times, most recently from 721ca30 to e024939 Compare October 19, 2023 14:24
Copy link
Member

@galderz galderz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @zakkak Have you got any plans to update the native ref guide? I think the section in https://quarkus.io/guides/native-reference#inspecting-native-executables could be expanded to touch on the techniques here.

Copy link

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice post. Looking forward to seeing it published!

@gastaldi gastaldi requested a review from maxandersen October 25, 2023 13:42
@zakkak
Copy link
Contributor Author

zakkak commented Oct 31, 2023

Uploading a screenshot since surge is not working.

image

@maxandersen can you please have a look and approve if everything looks OK?

@holly-cummins
Copy link
Contributor

@zakkak, a fix that should fix previews was merged yesterday night, so if you rebase and force push, that should trigger another build and (hopefully) a working preview.

@zakkak zakkak force-pushed the 2023-10-19-mandrel-23-0-image-size-increase branch from e024939 to aa1735f Compare October 31, 2023 10:22
@zakkak
Copy link
Contributor Author

zakkak commented Oct 31, 2023

The force push didn't help. Please see the screenshot above for a "preview"

@zakkak zakkak force-pushed the 2023-10-19-mandrel-23-0-image-size-increase branch from aa1735f to b72ec70 Compare November 1, 2023 07:02
@zakkak
Copy link
Contributor Author

zakkak commented Nov 1, 2023

Yeah, we finally have a surge review https://quarkus-website-pr-1818-preview.surge.sh/blog/mandrel-23-0-image-size-increase/

@zakkak zakkak force-pushed the 2023-10-19-mandrel-23-0-image-size-increase branch from b72ec70 to 72bcc6a Compare November 2, 2023 08:21
@zakkak zakkak merged commit 6faea0c into quarkusio:develop Nov 2, 2023
1 check passed
@zakkak zakkak deleted the 2023-10-19-mandrel-23-0-image-size-increase branch November 2, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants