Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle .exe extension if guessing path to Windows native executable #9516

Merged
merged 1 commit into from
May 22, 2020

Conversation

rquinio
Copy link
Contributor

@rquinio rquinio commented May 21, 2020

Follow-up on #7663, after experimenting with GraalVM on Windows.

This is the symmetric when running a NativeImageTest from the IDE of

if (IS_WINDOWS && !(nativeConfig.containerRuntime.isPresent() || nativeConfig.containerBuild)) {
//once image is generated it gets added .exe on Windows
executableName = executableName + ".exe";
}
that is used when launching the ITs from Maven.

======================================================================================
  native.image.path was not set, making a guess for the correct path of native image
  guessed path: C:\git_clones\quarkus\integration-tests\kafka\target\quarkus-integration-test-kafka-999-SNAPSHOT-runner.exe
======================================================================================

@geoand
Copy link
Contributor

geoand commented May 21, 2020

Seems reasonable to me, but would you be able to verify it @jaikiran ?

@jaikiran
Copy link
Member

This change looks fine to me.

@geoand
Copy link
Contributor

geoand commented May 22, 2020

Thanks for this

@geoand geoand merged commit 341a17c into quarkusio:master May 22, 2020
@gsmet gsmet added this to the 1.5.0.Final milestone May 26, 2020
@rquinio rquinio deleted the bugfix/guess-windows-native-path branch May 28, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants