Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to get native build work on Windows with GraalVM Java 11 #7663

Merged
merged 1 commit into from
Mar 7, 2020

Conversation

ctomc
Copy link
Contributor

@ctomc ctomc commented Mar 6, 2020

With this changes I am able to build (few) quickstarts natively on Windows 10 with GraalVM-java11-20.0.0

wildfly-common upgrade fixes wrongly included winsock.h when compiling on windows.
maven plugin fix is just to address final name which includes .exe

VS 2017 with some extras is needed for build to work.
For anyone looking what all tools are needed: (mostly got it from here)

For building on JDK 8, you need different set of build tools and properly set environment.

To install via chocolatey

choco install visualstudio2017community --version 15.9.17.0 --no-progress --package-parameters "--add Microsoft.VisualStudio.Component.VC.Tools.ARM64 --add Microsoft.VisualStudio.Component.VC.CMake.Project"

once installed environment can be set by running:

call "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvars64.bat"

@boring-cyborg boring-cyborg bot added area/core area/dependencies Pull requests that update a dependency file labels Mar 6, 2020
@machi1990 machi1990 added the env/windows Impacts Windows machines label Mar 7, 2020
@geoand
Copy link
Contributor

geoand commented Mar 7, 2020

cc @dmlloyd @gwenneg @jaikiran

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ctomc !

Looks good to me. I will let David merge it though as he's more aware of the changes in wildfly-common.

@gsmet
Copy link
Member

gsmet commented Mar 7, 2020

@michalszynkiewicz wondering if we should get this one into 1.3. It has an updated wildfly-common though. WDYT?

@michalszynkiewicz
Copy link
Member

@gsmet I'm okay with updating wildfly-common in 1.3

@gsmet gsmet requested a review from dmlloyd March 7, 2020 11:39
@dmlloyd dmlloyd merged commit 49d0129 into quarkusio:master Mar 7, 2020
@gsmet gsmet added this to the 1.3.0.CR2 milestone Mar 8, 2020
@maxandersen
Copy link
Member

waait - this is awesome! My first PR now make sense to rebase :)

#4103 colors galore! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/dependencies Pull requests that update a dependency file env/windows Impacts Windows machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants