Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Redis extension #9370

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Add a Redis extension #9370

merged 1 commit into from
Jul 6, 2020

Conversation

machi1990
Copy link
Member

@machi1990 machi1990 commented May 16, 2020 •
edited
Loading

Creates a vertx redis extension that provides different flavours of RedisAPI.

fixes #4453

QS PR here quarkusio/quarkus-quickstarts#572

/cc @pmlopes @geoand @gsmet @cescoffier

@boring-cyborg boring-cyborg bot added area/core area/dependencies Pull requests that update a dependency file area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure labels May 16, 2020
@machi1990 machi1990 mentioned this pull request May 16, 2020
Merged
10 tasks
@machi1990 machi1990 requested review from gsmet, cescoffier and geoand and removed request for gsmet May 16, 2020 09:06
@machi1990 machi1990 force-pushed the feat/vertx-redis-extension branch 3 times, most recently from 5b6f88c to b10c8c7 Compare May 16, 2020 13:04
@geoand
Copy link
Contributor

geoand commented May 16, 2020

Nice! I'll take a look on Monday

geoand
geoand reviewed May 16, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple initial high level comments

docs/src/main/asciidoc/redis.adoc Outdated Show resolved Hide resolved
...ions/vertx-redis/runtime/src/main/java/io/quarkus/vertx/redis/runtime/RedisAPIsProducer.java Outdated Show resolved Hide resolved
@machi1990 machi1990 force-pushed the feat/vertx-redis-extension branch 3 times, most recently from cb7a3b8 to bffa19b Compare May 16, 2020 19:21
@geoand
Copy link
Contributor

geoand commented May 19, 2020

I haven't been able to look at this because of the rush for 1.5.0.CR1, sorry

@geoand
Copy link
Contributor

geoand commented May 22, 2020

I think this is great work!

@machi1990
Copy link
Member Author

I think this is great work!

Great thanks for the review. I'll go on and update the suggested change about private final.

@machi1990 machi1990 force-pushed the feat/vertx-redis-extension branch from bffa19b to ff70985 Compare May 22, 2020 17:39
@machi1990 machi1990 force-pushed the feat/vertx-redis-extension branch 2 times, most recently from 53608c4 to 2a10b8a Compare May 23, 2020 08:01
@machi1990 machi1990 mentioned this pull request May 25, 2020
Closed
@machi1990 machi1990 marked this pull request as ready for review May 30, 2020 09:30
@machi1990 machi1990 force-pushed the feat/vertx-redis-extension branch from 2a10b8a to 1c39633 Compare May 30, 2020 09:36
@cescoffier
Copy link
Member

About the naming, could you use the same convention as the other projects:

in the "root" package having a RedisClient class, and in the reactive package having a "ReactiveRedisClient" class. See https://github.com/quarkusio/quarkus/tree/master/extensions/mailer/runtime/src/main/java/io/quarkus/mailer as an example.

@machi1990 machi1990 force-pushed the feat/vertx-redis-extension branch from 001ceb7 to 9650b0d Compare June 23, 2020 16:08
@machi1990 machi1990 requested a review from cescoffier June 23, 2020 16:10
@machi1990 machi1990 force-pushed the feat/vertx-redis-extension branch from 9650b0d to 4685fee Compare July 1, 2020 15:10
@machi1990
Copy link
Member Author

@gsmet @cescoffier ping, can you have a look? I have taken care of all the requested changes.

gsmet
gsmet requested changes Jul 3, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some very minor comments.

I think we should merge it once these small things sorted out and we can deal with the synthetic bean thing later if needed.

core/deployment/src/main/java/io/quarkus/deployment/Feature.java Outdated Show resolved Hide resolved
...client/deployment/src/main/java/io/quarkus/redis/client/deployment/RedisClientProcessor.java Show resolved Hide resolved
...client/deployment/src/main/java/io/quarkus/redis/client/deployment/RedisClientProcessor.java Outdated Show resolved Hide resolved
extensions/redis-client/runtime/pom.xml Outdated Show resolved Hide resolved
extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/RedisConfig.java Outdated Show resolved Hide resolved
@gsmet
Copy link
Member

gsmet commented Jul 3, 2020

@machi1990 nice work. Could you have a look at the minor comments above? Once these minor things are fixed, I would merge it and then deal with the synthetic bean thing in a followup if really needed.

@machi1990 machi1990 force-pushed the feat/vertx-redis-extension branch from 4685fee to 495e017 Compare July 3, 2020 14:34
@machi1990 machi1990 requested a review from gsmet July 3, 2020 14:38
@machi1990
Copy link
Member Author

@machi1990 nice work. Could you have a look at the minor comments above? Once these minor things are fixed, I would merge it and then deal with the synthetic bean thing in a followup if really needed.

@gsmet thanks for the review. Comments addressed.

@machi1990
feat: add a redis extension
76a6fcb 
Creates a redis-client extension that provides different flavours of
redis clients:
Imperative and Reactive client.

Fixes quarkusio#4453
@machi1990 machi1990 force-pushed the feat/vertx-redis-extension branch from 495e017 to 76a6fcb Compare July 4, 2020 20:16
@gsmet gsmet dismissed cescoffier’s stale review July 6, 2020 09:48

Comments addressed!

@gsmet
Copy link
Member

gsmet commented Jul 6, 2020

Cool! Let's get this one in. Thanks @machi1990 !

@gsmet gsmet merged commit 45a847b into quarkusio:master Jul 6, 2020
@gsmet gsmet added this to the 1.7.0 - master milestone Jul 6, 2020
@gsmet gsmet changed the title feat: add a redis extension Add a Redis extension Jul 6, 2020
@machi1990 machi1990 deleted the feat/vertx-redis-extension branch July 7, 2020 06:50
machi1990 added a commit to machi1990/quarkus that referenced this pull request Aug 14, 2020
@machi1990
feat(redis): allow to configure redis connection pool
508bfc0 
Follows up quarkusio#9370 (comment) and
quarkusio#4453 (comment)
machi1990 added a commit to machi1990/quarkus that referenced this pull request Aug 14, 2020
@machi1990
feat(redis): allow to configure redis connection pool
81257fb 
Follows up quarkusio#9370 (comment) and
quarkusio#4453 (comment)
@machi1990 machi1990 mentioned this pull request Aug 14, 2020
Merged
machi1990 added a commit to machi1990/quarkus that referenced this pull request Aug 17, 2020
@machi1990
feat(redis): allow to configure redis connection pool
5fd2f04 
Follows up quarkusio#9370 (comment) and
quarkusio#4453 (comment)
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Aug 24, 2020
@machi1990 @gsmet
feat(redis): allow to configure redis connection pool
257706f 
Follows up quarkusio#9370 (comment) and
quarkusio#4453 (comment)
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Aug 24, 2020
@machi1990 @gsmet
feat(redis): allow to configure redis connection pool
f59d8cc 
Follows up quarkusio#9370 (comment) and
quarkusio#4453 (comment)
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Aug 24, 2020
@machi1990 @gsmet
feat(redis): allow to configure redis connection pool
04da86d 
Follows up quarkusio#9370 (comment) and
quarkusio#4453 (comment)
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Aug 25, 2020
@machi1990 @gsmet
feat(redis): allow to configure redis connection pool
e0de698 
Follows up quarkusio#9370 (comment) and
quarkusio#4453 (comment)
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this pull request Sep 4, 2022
feat(redis): allow to configure redis connection pool
98d53d1 
    Follows up quarkusio/quarkus#9370 (comment) and
    quarkusio/quarkus#4453 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand left review comments

@mkouba mkouba mkouba left review comments

@pmlopes pmlopes pmlopes left review comments

@gsmet gsmet gsmet approved these changes

@cescoffier cescoffier Awaiting requested review from cescoffier

Assignees
No one assigned
Labels
area/core area/dependencies Pull requests that update a dependency file area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/redis release/noteworthy-feature
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Offer a Redis extension
6 participants
@machi1990 @geoand @cescoffier @gsmet @pmlopes @mkouba