Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(redis): add a redis quickstart #572

Merged
merged 1 commit into from
Jul 20, 2020
Merged

feat(redis): add a redis quickstart #572

merged 1 commit into from
Jul 20, 2020

Conversation

machi1990
Copy link
Member

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has native tests (mvn clean verify -Pnative)
  • makes sure the documentation must not be updated
  • links the documentation update pull request (if needed) - Add a Redis extension quarkus#9370
  • updates or creates the README.md file (with build and run instructions)
  • For new quickstart, is located in the directory component-quickstart
  • For new quickstart, is added to the root pom.xml and README.md

@machi1990 machi1990 mentioned this pull request May 16, 2020
Merged
@machi1990 machi1990 force-pushed the redis-quickstarts branch from 731dfb4 to 4c3ceac Compare May 16, 2020 16:42
@machi1990 machi1990 force-pushed the redis-quickstarts branch 2 times, most recently from 7c1b972 to 92b4e1d Compare June 23, 2020 16:09
@machi1990 machi1990 marked this pull request as ready for review June 23, 2020 18:23
@machi1990 machi1990 requested review from cescoffier and gsmet June 23, 2020 18:23
@gsmet gsmet force-pushed the redis-quickstarts branch from 92b4e1d to 0cbd19d Compare July 6, 2020 11:58
@gsmet
Copy link
Member

gsmet commented Jul 6, 2020

Rebased to force a CI run now that the main PR has been merged.

@machi1990
Copy link
Member Author

Rebased to force a CI run now that the main PR has been merged.

Thanks @gsmet looks like CI is all green. Can we get this merged?

@gsmet gsmet merged commit e040a25 into quarkusio:development Jul 20, 2020
@gsmet
Copy link
Member

gsmet commented Jul 20, 2020

Sorry, forgot about it :).

@machi1990 machi1990 deleted the redis-quickstarts branch July 20, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@cescoffier cescoffier Awaiting requested review from cescoffier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@machi1990 @gsmet