doc: active record and repository patterns #6923
Conversation
|
ping @gsmet, @FroMage, @emmanuelbernard can you give me feedback on this one ? |
|
The quickstart PR with the repository example is here: quarkusio/quarkus-quickstarts#448 |
|
@emmanuelbernard all your feedbacks are on sentences that was previously existing and I move around, so I assume you're OK with the overal changes ;) |
loicmathieu
force-pushed
the
feat/panache-entity-repository
branch
from
836f9d7 to
a537db7
Compare
|
@emmanuelbernard I updated the three sentences in both guides according to your feedback. |
|
thanks, though these were taken randomly and to be applied to all
sentences. But that's ok if that feedback is drop to go and deliver the
change.
…On Mon, Feb 3, 2020 at 4:48 PM Loïc Mathieu ***@***.***> wrote:
@emmanuelbernard <https://github.com/emmanuelbernard> I updated the three
sentences in both guides according to your feedback.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6923?email_source=notifications&email_token=AACJNWBHBPAZV22WMTPALUDRBA4FBA5CNFSM4KOLKJ42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKUKQSY#issuecomment-581478475>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACJNWEMVIOFQMPTFSUL3NTRBA4FBANCNFSM4KOLKJ4Q>
.
|
loicmathieu
force-pushed
the
feat/panache-entity-repository
branch
from
a537db7 to
7554454
Compare
|
@danielpetisme I added some part on the Hibernate with Panache documentation regarding the way to define Entities with the repository pattern. Feel free to give feedback. |
loicmathieu
force-pushed
the
feat/panache-entity-repository
branch
from
7554454 to
d311e32
Compare
|
@gsmet can you make a final review (you know my english ...) and merge this one ? |
|
I'll check the english and let you know :) |
| @@ -50,6 +50,9 @@ NOTE: the `list()` method might be surprising at first. It takes fragments of Pa | |||
| That makes for very concise but yet readable code. | |||
| MongoDB native queries are also supported. | |||
|
|
|||
| NOTE: what you just see is the link:https://www.martinfowler.com/eaaCatalog/activeRecord.html[active record pattern], sometimes just called the entity pattern. | |||
There was a problem hiding this comment.
Please just copy the changes I proposed in the other doc to this one :)
|
Don't forget to squash at the end of the process please :) |
Fixes quarkusio#6135 and quarkusio#6945 WIP Apply suggestions from code review will be squashed later Co-Authored-By: Georgios Andrianakis <[email protected]>
loicmathieu
force-pushed
the
feat/panache-entity-repository
branch
from
bc1ee4c to
737a697
Compare
|
@geoand I integrate all your suggestions, copied them to the MongoDB with Panache guide and squashed everything. Ready to be merged :) |
Fixes #6135
Fixes #6945
The following documentation changes are, for both MongoDB and Hibernate with Panache:
A PR on the quickstart will follows to duplicate the code to have exampes for both the active record and the repository patterns.