Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute parser - improve error messages #6467

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Qute parser - improve error messages #6467

merged 1 commit into from
Jan 9, 2020

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jan 8, 2020

gsmet
gsmet requested changes Jan 9, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a debatable code style comment. Could you have a look and see if you agree?

independent-projects/qute/core/src/main/java/io/quarkus/qute/Parser.java Outdated Show resolved Hide resolved
@mkouba mkouba requested a review from gsmet January 9, 2020 08:26
@gsmet gsmet added this to the 1.2.0 milestone Jan 9, 2020
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 9, 2020
@mkouba
Copy link
Contributor Author

mkouba commented Jan 9, 2020

Ah, a formatter issue again...

@geoand
Copy link
Contributor

geoand commented Jan 9, 2020

CI is reporting:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0-jboss-2:compile (default-compile) on project quarkus-qute-deployment: Compilation failure
[ERROR] /home/vsts/work/1/s/extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/TypeCheckInfo.java:[63,27] cannot find symbol
[ERROR]   symbol:   class TemplateException
[ERROR]   location: class io.quarkus.qute.deployment.TypeCheckInfo
[ERROR] -> [Help 1]

@mkouba
Copy link
Contributor Author

mkouba commented Jan 9, 2020

Yep, I know I need to rebase...

@mkouba mkouba merged commit a16aba0 into quarkusio:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.2.0.CR1
Development

Successfully merging this pull request may close these issues.

Qute parser - show the template path and line number in error messages
3 participants
@mkouba @geoand @gsmet