Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute parser - show the template path and line number in error messages #6164

Closed
mkouba opened this issue Dec 13, 2019 · 1 comment · Fixed by #6467
Closed

Qute parser - show the template path and line number in error messages #6164

mkouba opened this issue Dec 13, 2019 · 1 comment · Fixed by #6467
Assignees
Labels
area/qute The template engine kind/bug Something isn't working
Milestone

Comments

@mkouba
Copy link
Contributor

mkouba commented Dec 13, 2019

We do show this info when validating template expressions.

@mkouba mkouba added kind/bug Something isn't working area/qute The template engine labels Dec 13, 2019
@angelozerr
Copy link

angelozerr commented Dec 24, 2019

To support Qute validation inside an editor (with syntax error) like redhat-developer/vscode-quarkus#178 it's very important to have detailed information about the error:

  • the character, line where there are error or the offset
  • the full file name where there is an error

For instance:

Hello {name !

should report an error in line=0, character=11, or offset =11.

Ideally, the error should be an error range to highlight the {name interpolation:

  • start line=0, start character = 6, end line = 0, end character = 11

Error reporting is an hard thing to manage but please consider it if you want to have an advanced editor which highlights syntax error.

If this Qute parser could be more tolerant we could report several errors and not only the first error.

@mkouba mkouba self-assigned this Jan 8, 2020
@mkouba mkouba added this to the 1.2.0 milestone Jan 8, 2020
mkouba added a commit to mkouba/quarkus that referenced this issue Jan 8, 2020
mkouba added a commit to mkouba/quarkus that referenced this issue Jan 8, 2020
mkouba added a commit to mkouba/quarkus that referenced this issue Jan 9, 2020
mkouba added a commit to mkouba/quarkus that referenced this issue Jan 9, 2020
mkouba added a commit to mkouba/quarkus that referenced this issue Jan 9, 2020
gwenneg pushed a commit to gwenneg/quarkus that referenced this issue Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qute The template engine kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants