Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create the test structure (unit and devmode test) when using create-extension Maven Mojo #5438

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

machi1990
Copy link
Member

@machi1990 machi1990 commented Nov 13, 2019

Fixes #3585

/cc @gsmet @ppalaga

@ppalaga
Copy link
Contributor

ppalaga commented Nov 13, 2019

The new feature in itself looks good, the question is only, whether options to turn off the generation of the new kinds of tests would make sense. I think unit tests and dev mode tests rarely make sense in Camel Quarkus. WDYT, @lburgazzoli ?

@machi1990
Copy link
Member Author

Tests failure related. I'll need to add test :-)

@machi1990
Copy link
Member Author

The new feature in itself looks good, the question is only, whether options to turn off the generation of the new kinds of tests would make sense. I think unit tests and dev mode tests rarely make sense in Camel Quarkus. WDYT, @lburgazzoli ?

@ppalaga thanks for the feedback. You are thinking something like -Dignore-unit-test?

@ppalaga
Copy link
Contributor

ppalaga commented Nov 13, 2019

You are thinking something like -Dignore-unit-test?

Yes, but ideally with no-negated semantics, something like

    @Parameter(property = "quarkus.generateUnitTest", defaultValue = "true")
    boolean generateUnitTest;

    @Parameter(property = "quarkus.generateDevModeTest", defaultValue = "true")
    boolean generateDevModeTest;

@machi1990
Copy link
Member Author

@Parameter(property = "quarkus.generateUnitTest", defaultValue = "true")
boolean generateUnitTest;

@Parameter(property = "quarkus.generateDevModeTest", defaultValue = "true")
boolean generateDevModeTest;

Much better. Thanks, this is a useful addition. Let me get to it.

@machi1990
Copy link
Member Author

@ppalaga would you have some time to have another look at the PR ? Thanks.

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Camel Quarkus, seems to work. Thanks!

@machi1990 machi1990 requested a review from gsmet November 14, 2019 06:35
@machi1990 machi1990 requested review from gsmet and removed request for gsmet November 21, 2019 07:07
gsmet
gsmet previously requested changes Nov 28, 2019
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some questions.

@machi1990
Copy link
Member Author

@gsmet ping.

xumk pushed a commit to xumk/quarkus that referenced this pull request Oct 14, 2020
… using create-extension Maven Mojo.

This reverts commit 3495f91.

Follows up quarkusio#12687 and quarkusio#5438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the test structure when using create-extension Maven Mojo.
4 participants