-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create the test structure (unit and devmode test) when using create-extension Maven Mojo #5438
Conversation
The new feature in itself looks good, the question is only, whether options to turn off the generation of the new kinds of tests would make sense. I think unit tests and dev mode tests rarely make sense in Camel Quarkus. WDYT, @lburgazzoli ? |
Tests failure related. I'll need to add test :-) |
@ppalaga thanks for the feedback. You are thinking something like |
Yes, but ideally with no-negated semantics, something like
|
Much better. Thanks, this is a useful addition. Let me get to it. |
@ppalaga would you have some time to have another look at the PR ? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Camel Quarkus, seems to work. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some questions.
devtools/maven/src/main/java/io/quarkus/maven/CreateExtensionMojo.java
Outdated
Show resolved
Hide resolved
devtools/maven/src/main/java/io/quarkus/maven/CreateExtensionMojo.java
Outdated
Show resolved
Hide resolved
272fde6
to
fc45f47
Compare
@gsmet ping. |
… using create-extension Maven Mojo. This reverts commit 3495f91. Follows up quarkusio#12687 and quarkusio#5438
… using create-extension Maven Mojo. This reverts commit 3495f91. Follows up quarkusio#12687 and quarkusio#5438
Fixes #3585
/cc @gsmet @ppalaga