Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable creation of the test structure (unit and devmode test) when using create-extension Maven Mojo. #12690

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

machi1990
Copy link
Member

Fixes #3585

This reverts commit 3495f91.

Follows up #12687 and #5438

/cc @gastaldi this should fix the failing tests.

… using create-extension Maven Mojo.

This reverts commit 3495f91.

Follows up quarkusio#12687 and quarkusio#5438
@machi1990 machi1990 changed the title re-enable creation of the test structure (unit and devmode test) when using create-extension Maven Mojo. Re-enable creation of the test structure (unit and devmode test) when using create-extension Maven Mojo. Oct 13, 2020
@machi1990 machi1990 requested a review from gastaldi October 13, 2020 18:36
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great job!

@gastaldi gastaldi added this to the 1.10 - master milestone Oct 13, 2020
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 13, 2020
@jaikiran jaikiran merged commit 30fb9c1 into quarkusio:master Oct 14, 2020
@machi1990 machi1990 deleted the revisit-3585 branch October 14, 2020 06:32
machi1990 added a commit to machi1990/quarkus that referenced this pull request Oct 14, 2020
…introduce in create-extension mojo

It should at least be 1.10.0 and not 1.3.0.

Follows up quarkusio#12690
machi1990 added a commit to machi1990/quarkus that referenced this pull request Oct 14, 2020
…introduced in create-extension mojo

It should at least be 1.10.0 and not 1.3.0.

Follows up quarkusio#12690
xumk pushed a commit to xumk/quarkus that referenced this pull request Oct 14, 2020
…introduced in create-extension mojo

It should at least be 1.10.0 and not 1.3.0.

Follows up quarkusio#12690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the test structure when using create-extension Maven Mojo.
4 participants