Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements for config doc generation #42455

Merged
merged 10 commits into from
Aug 11, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 9, 2024

Fixes #42374
Fixes #42370
Fixes #42379
Fixes #42371
Fixes #42372
Fixes #42452

These are just small improvements + fixes and clean up.

@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation labels Aug 9, 2024
gsmet added 10 commits August 10, 2024 19:05
This is an improvement over what we had.
Fixes quarkusio#42374
We might sometimes want to include smaller section files in specific
paragraphs and the whole document at the end.
It wasn't possible until now because ids would have conflicted.

Fixes quarkusio#42371
This is useful in extreme cases such as with ConfigConfig.

Fixes quarkusio#42372
This way, it can more easily get reused by a potential Gradle plugin.
There is a good chance we don't have them working in the Quarkiverse doc
so let's be cautious.
@gsmet gsmet force-pushed the use-tooltip-for-default-value branch from 3509ad8 to 2b8bd83 Compare August 10, 2024 17:05
@gsmet gsmet marked this pull request as ready for review August 10, 2024 17:06
@gsmet gsmet requested review from gastaldi and aloubyansky August 10, 2024 17:06
Copy link

quarkus-bot bot commented Aug 10, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 2b8bd83.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Aug 10, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 2b8bd83.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.testFieldAccess - History

  • Expecting actual not to be null - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual not to be null
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest$FieldAccessEnhancedDelegate$1.assertValue(PublicFieldAccessInheritanceTest.java:132)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.doTestFieldAccess(PublicFieldAccessInheritanceTest.java:91)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.testFieldAccess(PublicFieldAccessInheritanceTest.java:52)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:499)

@gsmet
Copy link
Member Author

gsmet commented Aug 11, 2024

@yrodiere @marko-bekhta the flaky test is a bit concerning here ^

@gsmet gsmet merged commit 574428f into quarkusio:main Aug 11, 2024
70 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 11, 2024
Copy link

🙈 The PR is closed and the preview is expired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment