Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure dev-ui relocation are added to the importmap #41966

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

phillip-kruger
Copy link
Member

@phillip-kruger phillip-kruger commented Jul 18, 2024

related to #41875

I also added a test case to make sure relocations is always included

I also added a commit to fix #41868

@phillip-kruger phillip-kruger requested a review from gsmet July 18, 2024 00:37
@phillip-kruger phillip-kruger force-pushed the dev-ui-relocation-fix branch from 5e2caaa to 358daa1 Compare July 18, 2024 04:07
@gsmet gsmet added triage/backport triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jul 18, 2024
Copy link

quarkus-bot bot commented Jul 18, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a0b8b0d.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Native Tests - HTTP Build Failures Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ Native Tests - HTTP #

- Failing: integration-tests/rest-client-reactive 

📦 integration-tests/rest-client-reactive

Failed to execute goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore (wrong-host-truststore) on project quarkus-integration-test-rest-client-reactive: Execution wrong-host-truststore of goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore failed: java.net.ConnectException: Connection timed out


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/virtual-threads/grpc-virtual-threads

io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testUnary - History

  • INTERNAL: Half-closed without a request - io.grpc.StatusRuntimeException
io.grpc.StatusRuntimeException: INTERNAL: Half-closed without a request
	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:268)
	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:249)
	at io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:167)
	at io.grpc.testing.integration.TestServiceGrpc$TestServiceBlockingStub.unaryCall(TestServiceGrpc.java:220)
	at io.quarkus.grpc.example.streaming.VirtualThreadTestBase.testUnary(VirtualThreadTestBase.java:33)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:973)

@gsmet gsmet merged commit ece35bc into quarkusio:main Jul 18, 2024
51 of 52 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 18, 2024
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 18, 2024
@gsmet gsmet modified the milestones: 3.14 - main, 3.13.0 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregator scans built-in mvnpm jars twice for imports
2 participants