Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update importmap to 1.0.11 #41875

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

phillip-kruger
Copy link
Member

This contains @gsmet classloading fix

Signed-off-by: Phillip Kruger <[email protected]>
@phillip-kruger phillip-kruger requested a review from gsmet July 13, 2024 13:04
@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Jul 13, 2024
@gsmet
Copy link
Member

gsmet commented Jul 13, 2024

Ah let me add my work to your PR, then :).

@gsmet
Copy link
Member

gsmet commented Jul 13, 2024

@phillip-kruger I let you have a look at the commit I added, it makes use of the new method I introduced - that was all part of a plan \o/.

Copy link

quarkus-bot bot commented Jul 13, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4694e5a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Copy link
Member Author

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet as long as the importmap looks the same we are good !

@gsmet gsmet merged commit a52fa86 into quarkusio:main Jul 16, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 16, 2024
@phillip-kruger
Copy link
Member Author

@gsmet - This breaks dev-ui namespace relocations. I am providing a fix for the new CR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants