Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JsonObjectValueResolver to qute #41403

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Add JsonObjectValueResolver to qute #41403

merged 1 commit into from
Jun 28, 2024

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Jun 24, 2024 •
edited
Loading

Fixes #41390

@quarkus-bot quarkus-bot bot added the area/qute The template engine label Jun 24, 2024
@mcruzdev
Copy link
Contributor Author

I am waiting a definition from maintainers on issue #41390.

@mcruzdev mcruzdev force-pushed the issue-41390 branch 2 times, most recently from 571c8c5 to f65eae6 Compare June 25, 2024 18:04
@mcruzdev mcruzdev marked this pull request as ready for review June 25, 2024 18:04
@mcruzdev mcruzdev force-pushed the issue-41390 branch 2 times, most recently from 93f9e95 to f6bd6b0 Compare June 25, 2024 18:12
@mcruzdev mcruzdev requested review from mkouba and ia3andy June 25, 2024 18:13
@ia3andy ia3andy mentioned this pull request Jun 26, 2024
Merged
@ia3andy
Copy link
Contributor

ia3andy commented Jun 27, 2024

@mkouba good to go?

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
mkouba
mkouba reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good now! I've added one last comment...

...ns/qute/runtime/src/main/java/io/quarkus/qute/runtime/jsonobject/JsonObjectConfigurator.java Outdated Show resolved Hide resolved
@mcruzdev mcruzdev requested a review from mkouba June 27, 2024 17:09
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 28, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jun 28, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4626737.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit 3669610 into quarkusio:main Jun 28, 2024
23 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 28, 2024
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 28, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jun 28, 2024
@mkouba
Copy link
Contributor

mkouba commented Jun 28, 2024

@mcruzdev Thanks for your contribution!

@ia3andy
Copy link
Contributor

ia3andy commented Jun 28, 2024

Another great PR @mcruzdev thanks!

@mkouba mkouba mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

@ia3andy ia3andy Awaiting requested review from ia3andy

Assignees
No one assigned
Labels
area/qute The template engine kind/enhancement New feature or request
Projects
None yet
Milestone
3.13.0.CR1
Development

Successfully merging this pull request may close these issues.

JsonObject template extension for Qute built-in
3 participants
@mcruzdev @ia3andy @mkouba