Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonObject template extension for Qute built-in #41390

Closed
ia3andy opened this issue Jun 24, 2024 · 4 comments · Fixed by #41403
Closed

JsonObject template extension for Qute built-in #41390

ia3andy opened this issue Jun 24, 2024 · 4 comments · Fixed by #41403
Labels
area/qute The template engine good first issue Good for newcomers kind/enhancement New feature or request
Milestone

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Jun 24, 2024

Description

This will be nice for quarkiverse/quarkus-roq#15

Implementation ideas

This need to be added in quarkus-qute, here is an existing implementation : https://github.com/quarkusio/quarkus/blob/2.16/extensions/vertx-http/deployment/src/main/java/io/quarkus/vertx/http/deployment/devmode/console/JsonObjectValueResolver.java

@ia3andy ia3andy added the kind/enhancement New feature or request label Jun 24, 2024
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Jun 24, 2024
Copy link

quarkus-bot bot commented Jun 24, 2024

/cc @mkouba (qute)

@ia3andy ia3andy added the good first issue Good for newcomers label Jun 24, 2024
@mcruzdev
Copy link
Contributor

Hi @mkouba and @ia3andy , how are you?

Correct me if I'm wrong.

To solve it we need to create a new ValueResolver as mentioned on the issue and add it here?

This solution is ok?

@mcruzdev
Copy link
Contributor

I opened a draft pull request, but I am not sure when the best place to add this resolver. If in EngineBuilder, Qute#newDefaultEngine() or another place.

@mkouba
Copy link
Contributor

mkouba commented Jun 25, 2024

Hi @mcruzdev, I added a comment there. Qute core is not the right place. It should go in the runtime module of the quarkus-qute extension. Ping me on zulip I'm happy to answer futher questions ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qute The template engine good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants