Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] 3.11.2 backports 1 #41093

Merged
merged 23 commits into from
Jun 11, 2024
Merged

[3.11] 3.11.2 backports 1 #41093

merged 23 commits into from
Jun 11, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jun 10, 2024

No description provided.

mkouba and others added 23 commits June 10, 2024 15:51
- resolves quarkusio#40648
- also add WebSocketConnection#closeReason() and
  WebSocketClientConnection#closeReason()
This is a "what do you think?" PR, not a "you must do this" PR. The expression "for bare mortal" isn't very idiomatic in English. I did a [quick google](https://www.google.com/search?client=firefox-b-e&q=%22bare+mortal%22#ip=1) to double-check, and the top hits were all this page, and then I found one other use: "how can a bare mortal like me ...". Most other uses were a Thomas Pynchon quote, "the bare mortal world that is our home”, where the phrase has a different meaning.

What I'd say is "mere mortals" instead. It's [widely used](https://www.google.com/search?q=for+mere+mortals) to mean "accessible".

Now, because it's so widely used, it's less distinctive, and it lacks some of the Franglish charm of "bare mortal." In interface design, we should always go for the principle of least surprise, but I'm less sure about what's best in language use.

(cherry picked from commit 7b1fe99)
It doesn't look very well. Let's just use the natural padding we have,
it's far better.

(cherry picked from commit e816a3c)
Signed-off-by: Phillip Kruger <[email protected]>
(cherry picked from commit ad8b37d)
Signed-off-by: Phillip Kruger <[email protected]>
(cherry picked from commit bb7760c)
- fix regression introduced in
quarkusio#33984
- if there are multiple type-safe templates with the same parameter
declaration then _no_ or _incomplete_ value resolver may be generated

(cherry picked from commit ba3f62a)
(cherry picked from commit ccc374a)
(cherry picked from commit 9a41042)
When starting dev mode, the debug port might not be free and we might
use a random one.
When restarting dev mode (for instance when you adjust the pom.xml), we
should try to reuse this port instead of defaulting to the initially non
free one.

Also the port being free is tested when we build `DevModeRunner`, so we
need to make sure we stop the old runner before build()ing the new
instance (and not just before we start the new one).

Fixes quarkusio#40848

(cherry picked from commit 2233494)
…ram(..)

Previously `?` in query parameter values where encoded as is which caused
invalid URL values. We now replace `?` characters in query parameter values with
`%3F`.

Fixes quarkusio#41060

Signed-off-by: Thomas Darimont <[email protected]>
(cherry picked from commit f244de0)
(cherry picked from commit 5d0a210)
Following quarkusio#40779 / agroal/agroal@6c62f82,
the exception message changed and is a bit more explicit.

(cherry picked from commit 2d99f1d)
@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/gradle Gradle area/maven area/oidc labels Jun 10, 2024
@quarkus-bot quarkus-bot bot added area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/resteasy-classic area/vertx labels Jun 10, 2024
@quarkus-bot quarkus-bot bot changed the title 3.11.2 backports 1 [3.11] 3.11.2 backports 1 Jun 10, 2024
Copy link

quarkus-bot bot commented Jun 10, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit acb6fa7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

github-actions bot commented Jun 10, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Jun 10, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit acb6fa7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 independent-projects/tools/analytics-common

io.quarkus.analytics.AnalyticsServiceTest.sendAnalyticsTest - History

  • Assertion condition defined as a Lambda expression in io.quarkus.analytics.AnalyticsServiceTest Expected at least one request matching: { "url" : "/v1/track", "method" : "POST" } Requests received: [ ] within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.analytics.AnalyticsServiceTest Expected at least one request matching: {
  "url" : "/v1/track",
  "method" : "POST"
}
Requests received: [ ] within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

@gsmet gsmet merged commit 8ea5fff into quarkusio:3.11 Jun 11, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/gradle Gradle area/maven area/oidc area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/resteasy-classic area/vertx triage/flaky-test
Projects
Development

Successfully merging this pull request may close these issues.