-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.11] 3.11.2 backports 1 #41093
[3.11] 3.11.2 backports 1 #41093
Conversation
- resolves quarkusio#40648 - also add WebSocketConnection#closeReason() and WebSocketClientConnection#closeReason()
(cherry picked from commit 514c426)
(cherry picked from commit 869f1e7)
This is a "what do you think?" PR, not a "you must do this" PR. The expression "for bare mortal" isn't very idiomatic in English. I did a [quick google](https://www.google.com/search?client=firefox-b-e&q=%22bare+mortal%22#ip=1) to double-check, and the top hits were all this page, and then I found one other use: "how can a bare mortal like me ...". Most other uses were a Thomas Pynchon quote, "the bare mortal world that is our home”, where the phrase has a different meaning. What I'd say is "mere mortals" instead. It's [widely used](https://www.google.com/search?q=for+mere+mortals) to mean "accessible". Now, because it's so widely used, it's less distinctive, and it lacks some of the Franglish charm of "bare mortal." In interface design, we should always go for the principle of least surprise, but I'm less sure about what's best in language use. (cherry picked from commit 7b1fe99)
Relates to: quarkusio#40999 (cherry picked from commit 5273ed0)
…nfiguration (cherry picked from commit 36f5043)
It doesn't look very well. Let's just use the natural padding we have, it's far better. (cherry picked from commit e816a3c)
(cherry picked from commit 5286ec9)
Signed-off-by: Phillip Kruger <[email protected]> (cherry picked from commit ad8b37d)
(cherry picked from commit 5ed60b9)
- fixes quarkusio#40981 (cherry picked from commit 76af842)
(cherry picked from commit 8cf8663)
Signed-off-by: Phillip Kruger <[email protected]> (cherry picked from commit bb7760c)
- fix regression introduced in quarkusio#33984 - if there are multiple type-safe templates with the same parameter declaration then _no_ or _incomplete_ value resolver may be generated (cherry picked from commit ba3f62a)
(cherry picked from commit ccc374a)
When starting dev mode, the debug port might not be free and we might use a random one. When restarting dev mode (for instance when you adjust the pom.xml), we should try to reuse this port instead of defaulting to the initially non free one. Also the port being free is tested when we build `DevModeRunner`, so we need to make sure we stop the old runner before build()ing the new instance (and not just before we start the new one). Fixes quarkusio#40848 (cherry picked from commit 2233494)
(cherry picked from commit 7bd6ce3)
…ram(..) Previously `?` in query parameter values where encoded as is which caused invalid URL values. We now replace `?` characters in query parameter values with `%3F`. Fixes quarkusio#41060 Signed-off-by: Thomas Darimont <[email protected]> (cherry picked from commit f244de0)
Fixes quarkusio#40987 (cherry picked from commit bdd407c)
(cherry picked from commit 5d0a210)
(cherry picked from commit fd55e78)
Following quarkusio#40779 / agroal/agroal@6c62f82, the exception message changed and is a bit more explicit. (cherry picked from commit 2d99f1d)
Status for workflow
|
🙈 The PR is closed and the preview is expired. |
Status for workflow
|
No description provided.