Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute: disable optimization of generated ValueResolvers for native builds #33984

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Qute: disable optimization of generated ValueResolvers for native builds #33984

merged 1 commit into from
Jun 13, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 12, 2023

@mkouba mkouba requested review from gastaldi and geoand June 12, 2023 13:59
@quarkus-bot quarkus-bot bot added area/core area/qute The template engine labels Jun 12, 2023
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 12, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 12, 2023

Failing Jobs - Building bad0ed1

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs
✖ JVM Tests - JDK 19 Build Failures Logs Raw logs
⌛ Native Tests - Misc3 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/amazon-lambda/deployment 
! Skipped: extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment integration-tests/amazon-lambda and 6 more

📦 extensions/amazon-lambda/deployment

✖ io.quarkus.amazon.lambda.deployment.testing.LambdaDevServicesContinuousTestingTestCase.testLambda line 48 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

⚙️ JVM Tests - JDK 19 #

- Failing: extensions/amazon-lambda/deployment 
! Skipped: extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment integration-tests/amazon-lambda and 6 more

📦 extensions/amazon-lambda/deployment

✖ io.quarkus.amazon.lambda.deployment.testing.LambdaDevServicesContinuousTestingTestCase.testLambda line 48 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

@mkouba mkouba merged commit 0f4c893 into quarkusio:main Jun 13, 2023
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jun 13, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone Jun 13, 2023
mkouba added a commit to mkouba/quarkus that referenced this pull request Jun 7, 2024
@mkouba
Qute: fix regression for optimized generated value resolvers
ba3f62a 
- fix regression introduced in
quarkusio#33984
- if there are multiple type-safe templates with the same parameter
declaration then _no_ or _incomplete_ value resolver may be generated
@mkouba mkouba mentioned this pull request Jun 7, 2024
Merged
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Jun 10, 2024
@mkouba @gsmet
Qute: fix regression for optimized generated value resolvers
fcd9579 
- fix regression introduced in
quarkusio#33984
- if there are multiple type-safe templates with the same parameter
declaration then _no_ or _incomplete_ value resolver may be generated

(cherry picked from commit ba3f62a)
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this pull request Jul 31, 2024
@mkouba @holly-cummins
Qute: fix regression for optimized generated value resolvers
e6de28e 
- fix regression introduced in
quarkusio#33984
- if there are multiple type-safe templates with the same parameter
declaration then _no_ or _incomplete_ value resolver may be generated
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Aug 7, 2024
@mkouba @gsmet
Qute: fix regression for optimized generated value resolvers
aa08129 
- fix regression introduced in
quarkusio#33984
- if there are multiple type-safe templates with the same parameter
declaration then _no_ or _incomplete_ value resolver may be generated

(cherry picked from commit ba3f62a)
danielsoro pushed a commit to danielsoro/quarkus that referenced this pull request Sep 20, 2024
@mkouba @danielsoro
Qute: fix regression for optimized generated value resolvers
42c4851 
- fix regression introduced in
quarkusio#33984
- if there are multiple type-safe templates with the same parameter
declaration then _no_ or _incomplete_ value resolver may be generated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/core area/qute The template engine kind/enhancement New feature or request
Projects
None yet
Milestone
3.2.0.CR1
Development

Successfully merging this pull request may close these issues.

Qute: disable optimization of generated value resolvers
3 participants
@mkouba @gastaldi @geoand