-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the target file in the Model #40869
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
the
area/devtools
Issues/PR related to maven, gradle, platform and cli tooling/plugins
label
May 28, 2024
This comment has been minimized.
This comment has been minimized.
gsmet
reviewed
May 28, 2024
...p/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/workspace/ModelUtils.java
Show resolved
Hide resolved
This is necessary so `maven-model-helper` can know which pom.xml the change refers to. - Fixes quarkusio#40853
quarkus-bot
bot
added
the
area/platform
Issues related to definition and interaction with Quarkus Platform
label
May 29, 2024
gsmet
approved these changes
May 30, 2024
It looks good to me but I'd like to give it a try since apparently CI didn't catch the issue. Probably not today though. |
gsmet
approved these changes
May 30, 2024
Tested and it works! |
9 tasks
jcarranzan
added a commit
to jcarranzan/quarkus-test-suite
that referenced
this pull request
Jun 4, 2024
jcarranzan
added a commit
to jcarranzan/quarkus-test-suite
that referenced
this pull request
Jun 4, 2024
fix style remove @disable test already fix quarkusio/quarkus#40869 rm Disable import
jcarranzan
added a commit
to jcarranzan/quarkus-test-suite
that referenced
this pull request
Jun 5, 2024
fix style remove @disable test already fix quarkusio/quarkus#40869 rm Disable import
rsvoboda
pushed a commit
to quarkus-qe/quarkus-test-suite
that referenced
this pull request
Jun 6, 2024
fix style remove @disable test already fix quarkusio/quarkus#40869 rm Disable import
fedinskiy
pushed a commit
to fedinskiy/quarkus-test-suite
that referenced
this pull request
Jun 6, 2024
fix style remove @disable test already fix quarkusio/quarkus#40869 rm Disable import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/devtools
Issues/PR related to maven, gradle, platform and cli tooling/plugins
area/platform
Issues related to definition and interaction with Quarkus Platform
kind/bugfix
triage/flaky-test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary so
maven-model-helper
can know which pom.xml the change refers to.