POM is not preserved when we add or remove extensions with CLI

[jcarranzan]

Describe the bug

I was testing the backport related to preserving POM integrity after adding an extension ( 2bb40f9).
However, it seems that POM integrity is still not preserved when we add or remove extensions through CLI commands.
I've created a reproducer to show you this behavior (git clone -b pom-preserve-cli https://github.com/jcarranzan/quarkus-reproducer.git).

Expected behavior

The POM retains the same structure and comments after adding or removing an extension.

Actual behavior

The POM is overwritten, and comments are not preserved.

How to Reproduce?

git clone -b pom-preserve-cli https://github.com/jcarranzan/quarkus-reproducer.git

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

3.8.999-SNAPSHOT

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[quarkus-bot]

/cc @ebullient (cli), @maxandersen (cli)

[gsmet]

Which command line did you run, exactly? Wondering if you were using the correct version of the plugin, as I think you might have to specify it on the command line.

[rsvoboda]

@gsmet https://github.com/jcarranzan/quarkus-reproducer/blob/pom-preserve-cli/src/test/java/io/quarkus/QuarkusCliPomIntegrityIT.java is the test, using io.quarkus.test.bootstrap.QuarkusCliClient;

[rsvoboda]

@jcarranzan mvn clean verify -Dquarkus.platform.version=3.10.2 fails too

I don't think you persist comment addition back to the pom.xml file after https://github.com/jcarranzan/quarkus-reproducer/blob/pom-preserve-cli/src/test/java/io/quarkus/QuarkusCliPomIntegrityIT.java#L39C34-L39C41

[gsmet]

I would recommend to start with a POM file containing comments and new lines.

[jcarranzan]

I tweak the test (https://github.com/jcarranzan/quarkus-reproducer/blob/pom-preserve-cli/src/test/java/io/quarkus/QuarkusCliPomIntegrityIT.java) with the @rsvoboda suggestion,

1. It creates a Quarkus application named APP_NAME using the QuarkusCliClient.
2. Reads the initial content of the POM file.
3. Adds the COMMENT at line 1, and writes the modified content back to the file.
4. Next, it installs the new extension usingapp.installExtension()with QuarkusCliClient from QuarkusCliRestService .
5. After installation, it reads the updated content of the POM file and asserts that it contains the comment added.
   Then the test fails because the comment is not there.

[rsvoboda]

Thanks @jcarranzan for the update.

I tried with quarkus command (version 3.10.2) and I can confirm that the comments are not preserved @gsmet

quarkus create app foo:bat:1.0
cd bat
# open pom.xml, add comment to the file, save
quarkus ext add quarkus-kafka-client
# check pom.xml, comment is not there

[rsvoboda]

@gastaldi can you look into this? (As you worked on #39382)

[gastaldi]

I've investigated and figured out that's caused by 68a1bbe, I'm working on a fix right now.

[gastaldi]

@jcarranzan I've tested with your reproducer with the latest Quarkus CLI (using jbang app install --force --name quarkus ~/.m2/repository/io/quarkus/quarkus-cli/999-SNAPSHOT/quarkus-cli-999-SNAPSHOT-runner.jar)
and it works with my patch if you add the comment inside the pom.xml (eg. initialPomContent.add(3, COMMENT);).

[jcarranzan]

Ok, thank you @gastaldi.
I've tried it but still not worked, I guess just because I don't have your patch yet merged in the branch...

[gastaldi]

@jcarranzan yes, you need to build my branch to test that