Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt new behavior of System.console() since JDK22 #40127

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Adapt new behavior of System.console() since JDK22 #40127

merged 1 commit into from
Apr 22, 2024

Conversation

Eng-Fouad
Copy link
Contributor

Resolves #40087

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 19, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c881b5f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

gsmet
gsmet approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR.

I think not registering the class for reflection will be OK as I don't expect this code to run in native.

@gsmet gsmet merged commit 99d6c7b into quarkusio:main Apr 22, 2024
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone Apr 22, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Apr 22, 2024
@Eng-Fouad Eng-Fouad deleted the #40087 branch April 22, 2024 08:33
@gsmet gsmet modified the milestones: 3.11 - main, 3.10.0 Apr 23, 2024
@gsmet gsmet modified the milestones: 3.10.0, 3.9.5 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/core kind/enhancement New feature or request
Projects
None yet
Milestone
3.9.5
Development

Successfully merging this pull request may close these issues.

Adapt new behavior of System.console() since JDK22
2 participants
@Eng-Fouad @gsmet