Adapt new behavior of System.console() since JDK22

[Eng-Fouad]

Description

Since JDK22:

In JDK 22, System.console() has been changed to return a Console with enhanced editing features that improve the experience of programs that use the Console API. In addition, System.console() now returns a Console object when the standard streams are redirected or connected to a virtual terminal. Prior to JDK 22, System.console() instead returned null for these cases. This change may impact code that checks the return from System.console() to test if the JVM is connected to a terminal. If required, the -Djdk.console=java.base flag will restore the old behavior where the console is only returned when it is connected to a terminal. Starting JDK 22, one could also use the new Console.isTerminal() method to test if the console is connected to a terminal.

I looked into Quarkus codebase and I found the following snippets that might need to be changed:

quarkus/core/devmode-spi/src/main/java/io/quarkus/dev/console/QuarkusConsole.java

Lines 121 to 123 in 3b97e89

	// on sane operating systems having a console is a good indicator
	// you are attached to a TTY with colors.
	return System.console() != null;

quarkus/core/devmode-spi/src/main/java/io/quarkus/dev/console/BasicConsole.java

Lines 32 to 37 in 3b97e89

	if (console != null) {
	console.writer().print(s);
	console.writer().flush();
	} else {
	printStream.print(s);
	}

quarkus/independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/utils/Prompt.java

Lines 27 to 33 in 3b97e89

	Optional<Console> console = Optional.ofNullable(System.console());
	String response = console
	.map(c -> c.readLine(prompt + choices + optionalQuestionMark, args).trim().toLowerCase())
	.orElse(defaultValue ? "y" : "n");
	if (response.isBlank()) {
	return defaultValue;
	}

Implementation ideas

Change System.console() != null to System.console() != null && System.console().isTerminal().

Since isTerminal() is a new method introduced in JDK22, we can either:

• Call it via reflection.
• Use "multi-release jar" feature (JEP238).

[quarkus-bot]

/cc @Sanne (core), @aloubyansky (core), @gsmet (core), @radcortez (core), @stuartwdouglas (core)

[stuartwdouglas]

I think using reflection would be the simplest approach here, ideally guarded by a version check so we don't make the reflection calls for older versions.

[geoand]

I think using reflection would be the simplest approach here, ideally guarded by a version check so we don't make the reflection calls for older versions.

+1 as I am pretty sure we are not setup for MR-Jars in the main Quarkus repo.

[geoand]

@Eng-Fouad would you like to contribute this?

[Eng-Fouad]

@Eng-Fouad would you like to contribute this?

Submitted a PR. Do we need to register isTerminal for reflection in native image?

[stuartwdouglas]

AFAIK graal should be able to detect this case automatically because it is basically hard coded.