-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OIDC cookie related tenant id and chunk calculation issues #39850
Fix OIDC cookie related tenant id and chunk calculation issues #39850
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
84477fa
to
71861ab
Compare
Thanks @gastaldi, I added some doc text between @michalvavrik Please confirm when you get a chance that we are in agreement re the doc-ed order of tenant resolution :-) A minor follow up optimization is also possible ( |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @michalvavrik @pedroigor Hi Pedro, have a look if you get a chance, I'll keep it for another day, see the PR description, it is mainly about bug fixes related to the cookie max size (and the subsequent splits), making sure the old tenant's cookies are cleaned up if for some reasons and improving the multi-tenancy docs. |
71861ab
to
61529c2
Compare
I've picked up the direct session cookie encryption update just to make sure it does not impact anything here (it must not) |
Status for workflow
|
Status for workflow
|
I suppose I'll go ahead, I'm seeing some strange Keycloak 24.0.2 test errors, and this PR fixes a few session and tenant resolution issues, so may be it can help. |
🙈 The PR is closed and the preview is expired. |
Fixes #39849.
Fixes #39417.
Fixes #38535.
This PR fixes several issues related to the OIDC tenant resolution and the session management, all discovered while looking at the test failure as a result of the initial work with #39417.
As it happens, the initial #39417 fix exposed these problems, how the OIDC quickstart tenancy test was passing when the tenants are switched with the same session cookie path before is still a mystery to me.
So, this PR does the following:
OidcAuthenticationMechanism#resolve
3 timesThis is a technical PR which tries to cover the grey areas related to the session cookie splitting, and provide the better advice on how to manage tenants