Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC automatic session cookie splitting is broken #39849

Closed
sberyozkin opened this issue Apr 2, 2024 · 2 comments · Fixed by #39850
Closed

OIDC automatic session cookie splitting is broken #39849

sberyozkin opened this issue Apr 2, 2024 · 2 comments · Fixed by #39850
Assignees
Labels
area/oidc kind/bug Something isn't working
Milestone

Comments

@sberyozkin
Copy link
Member

Describe the bug

I've opened a can of worms by starting looking into the OIDC tenant resolution optimization. But I'm glad we started looking into it as a few hidden issues have been discovered, one of them is that the the automatic session cookie splitting feature, when the value length is >= 4096 is in fact broken. This is not a blocker as the other existing options for managing large session cookies work.

The tests are passing because HtmlUnit does not act as a real browser. But Chrome, Firefox do drop the cookies whose values are <= 4096. The reason is simple: it is the total Set-Cookie expression length which must not exceed 4096 bytes, it includes the name, and all attributes like Expires, Path, Domain.

I've spent days chasing some unexpected test failures before I pinned it down

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@sberyozkin sberyozkin added the kind/bug Something isn't working label Apr 2, 2024
Copy link

quarkus-bot bot commented Apr 2, 2024

/cc @pedroigor (oidc)

@quarkus-bot quarkus-bot bot added the area/oidc label Apr 2, 2024
@sberyozkin sberyozkin self-assigned this Apr 2, 2024
@sberyozkin
Copy link
Member Author

#37816 is somewhat related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oidc kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant