Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move junit-pioneer to build-parent #39166

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Mar 4, 2024

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Mar 4, 2024
- This removes the org.junitpioneer:junit-pioneer dependency from the quarkus-bom and moves to build-parent
@gastaldi gastaldi marked this pull request as ready for review March 4, 2024 21:43
Copy link

quarkus-bot bot commented Mar 5, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8754bfa.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.EndUserEnabledTest.baseTest - History

  • AttributesMap{data={http.client_ip=127.0.0.1, net.host.name=localhost, user_agent.original=Apache-HttpClient/4.5.14 (Java/17.0.10), http.target=/otel/enduser, code.function=dummy, net.host.port=8081, net.protocol.name=http, http.response_content_length=0, http.scheme=http, http.method=GET, http.status_code=200, code.namespace=io.quarkus.it.opentelemetry.util.EndUserResource, http.route=/otel/enduser}, capacity=128, totalAddedValues=13} ==> expected: <testUser> but was: <null> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: AttributesMap{data={http.client_ip=127.0.0.1, net.host.name=localhost, user_agent.original=Apache-HttpClient/4.5.14 (Java/17.0.10), http.target=/otel/enduser, code.function=dummy, net.host.port=8081, net.protocol.name=http, http.response_content_length=0, http.scheme=http, http.method=GET, http.status_code=200, code.namespace=io.quarkus.it.opentelemetry.util.EndUserResource, http.route=/otel/enduser}, capacity=128, totalAddedValues=13} ==> expected: <testUser> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1156)
	at io.quarkus.it.opentelemetry.EndUserEnabledTest.evaluateAttributes...

@geoand geoand merged commit 14a61cc into quarkusio:main Mar 5, 2024
61 of 63 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 5, 2024
@gsmet
Copy link
Member

gsmet commented Mar 5, 2024

That makes perfect sense but we need to document it in the migration guide.

@gastaldi gastaldi deleted the junit_pioneer branch March 5, 2024 14:45
@gastaldi
Copy link
Contributor Author

gastaldi commented Mar 5, 2024

That makes perfect sense but we need to document it in the migration guide.

Added here: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.9#junitpioneer-removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants