Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JUnit Pioneer to 2.2.0 #39165

Closed

Conversation

gonmmarques
Copy link
Contributor

Hello,

I noticed that in the Quarkus BOM JUnit Pioneer was still in version 1.5.0 (released in November 2021) and was wondering if this could be bumped.

I was a bit unsure on how to test this, I ended up just forking and running the ci workflow https://github.com/gonmmarques/quarkus/actions/runs/8141924367 (it seems everything was ok, except the JVM tests which would take very long).

Let me know if this request makes sense, and if so how should I proceed.

Thanks in advance.

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Mar 4, 2024
Copy link

quarkus-bot bot commented Mar 4, 2024

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@gastaldi gastaldi changed the title build: Bump JUnit Pioneer Bump JUnit Pioneer to 2.2.0 Mar 4, 2024
@gastaldi
Copy link
Contributor

gastaldi commented Mar 4, 2024

@gonmmarques while you're at it, how about adding it to the dependabot.yml descriptor too?

@gastaldi
Copy link
Contributor

gastaldi commented Mar 4, 2024

OTOH I think we should remove that dependency from the BOM, as it appears it is only used in two tests in the quarkus-rest-client-reactive-deployment module.

WDYT @geoand @gsmet ?

Copy link

quarkus-bot bot commented Mar 5, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c468420.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.EndUserEnabledTest.baseTest - History

  • AttributesMap{data={http.client_ip=127.0.0.1, net.host.name=localhost, user_agent.original=Apache-HttpClient/4.5.14 (Java/17.0.10), http.target=/otel/enduser, code.function=dummy, net.host.port=8081, net.protocol.name=http, http.response_content_length=0, http.scheme=http, http.method=GET, http.status_code=200, code.namespace=io.quarkus.it.opentelemetry.util.EndUserResource, http.route=/otel/enduser}, capacity=128, totalAddedValues=13} ==> expected: <testUser> but was: <null> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: AttributesMap{data={http.client_ip=127.0.0.1, net.host.name=localhost, user_agent.original=Apache-HttpClient/4.5.14 (Java/17.0.10), http.target=/otel/enduser, code.function=dummy, net.host.port=8081, net.protocol.name=http, http.response_content_length=0, http.scheme=http, http.method=GET, http.status_code=200, code.namespace=io.quarkus.it.opentelemetry.util.EndUserResource, http.route=/otel/enduser}, capacity=128, totalAddedValues=13} ==> expected: <testUser> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1156)
	at io.quarkus.it.opentelemetry.EndUserEnabledTest.evaluateAttributes...

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
  • io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:87) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) at java.base/java.lang.reflect.Method.invoke(Method.java:580) - java.lang.RuntimeException
java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final
	at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:87)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:849)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:256)

@geoand
Copy link
Contributor

geoand commented Mar 5, 2024

OTOH I think we should remove that dependency from the BOM, as it appears it is only used in two tests in the quarkus-rest-client-reactive-deployment module.

+1

@gonmmarques
Copy link
Contributor Author

@gonmmarques while you're at it, how about adding it to the dependabot.yml descriptor too?

Could do that as well.

OTOH I think we should remove that dependency from the BOM, as it appears it is only used in two tests in the quarkus-rest-client-reactive-deployment module.

WDYT @geoand @gsmet ?

Or if you go with that as well :)

Thanks btw for taking a look at this.

@geoand
Copy link
Contributor

geoand commented Mar 5, 2024

@gastaldi did that here.

So let's close this.

Thanks for bringing this to our attention!

@geoand geoand closed this Mar 5, 2024
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Mar 5, 2024
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 5, 2024
@gonmmarques
Copy link
Contributor Author

@gastaldi did that here.

So let's close this.

Thanks for bringing this to our attention!

Sounds good, thanks.

@gonmmarques gonmmarques deleted the build/bump-junit-pioneer branch March 5, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file triage/flaky-test triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants