Allows the HTTP server to use PEM truststore #39106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
sberyozkin
reviewed
Mar 1, 2024
sberyozkin
approved these changes
Mar 1, 2024
|
@sberyozkin the documentation is on https://github.com/cescoffier/certificate-generator until we move it. |
This comment has been minimized.
This comment has been minimized.
|
The BC JSSE test failure is likely related as it uses the cred provider |
|
Yes, I had to change a few things in the credential provider support. I will have a look on Monday. |
Previously, configuring the truststore with PEM files for mTLS (mutual TLS) usage was not supported, limiting options to JKS and P12 formats. This commit addresses this limitation by introducing support for PEM truststores in the HTTP server configuration. Additionally, this commit accomplishes the following tasks: - Removes hand-crafted certificates. - Fixes issues related to alias passwords. - Deprecates the usage of "key" properties, replacing them with "alias" properties for clarity and consistency.
cescoffier
force-pushed
the
vertx-http-pem-truststore
branch
from
69294a2 to
0fddc50
Compare
|
@sberyozkin it should be fixed now - was a bug in the new code. |
Status for workflow
|
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, configuring the truststore with PEM files for mTLS (mutual TLS) usage was not supported, limiting options to JKS and P12 formats. This commit addresses this limitation by introducing support for PEM truststores in the HTTP server configuration.
Additionally, this commit accomplishes the following tasks: