Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set keystore file type as required due to upstream changes the type can't be inferred anymore #1700

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Set keystore file type as required due to upstream changes the type can't be inferred anymore #1700

merged 1 commit into from
Mar 4, 2024

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Mar 4, 2024 •
edited
Loading

Summary

Sets keystore file type as tests are now failing. See quarkusio/quarkus#39106 and quarkusio/quarkus#39151 for explanation what changed and why it is okay.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from gtroitsk March 4, 2024 14:35
@michalvavrik michalvavrik changed the title Set keystore file type as required Set keystore file type as required due to upstream changes the type can't be inferred anymore Mar 4, 2024
@michalvavrik michalvavrik merged commit e3d7dc9 into quarkus-qe:main Mar 4, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/set-trustore-explicitly branch March 4, 2024 15:54
@jedla97 jedla97 mentioned this pull request Mar 6, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtroitsk gtroitsk gtroitsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @gtroitsk