3.7.4 backports 1 #38864
Merged
3.7.4 backports 1 #38864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 03ed847)
(cherry picked from commit 7c74b90)
This is a consequence of renaming the extension in 3.7. I also added the guide to the subextensions. (cherry picked from commit ccf5512)
Closes quarkusio#38721 (cherry picked from commit 2b3e071)
Fixes: quarkusio#38798 (cherry picked from commit c18c33f)
This commit fixes 2 cases when invalid bytecode is generated: - when a `void`-returning method is intercepted and also decorated - when an interceptor declared on a target class returns `void` (cherry picked from commit 1397241)
Fixes: quarkusio#38802 (cherry picked from commit b3a9aa7)
(cherry picked from commit c4433ba)
(cherry picked from commit 554bb02)
(cherry picked from commit 1f231f0)
(cherry picked from commit 8c0c413)
(cherry picked from commit 1ec895c)
Fixes: quarkusio#38837 (cherry picked from commit 8178c7f)
`org.apache.kafka.common.security.oauthbearer.OAuthBearerValidatorCallbackHandler` depends on the optional `org.jose4j.keys.resolvers.VerificationKeyResolver` so it should only be registered when the latter is present, similarly to `org.apache.kafka.common.security.oauthbearer.secured.OAuthBearerValidatorCallbackHandler` Closes quarkusio#38851 (cherry picked from commit d88e0bd)
The annotation transformer in `SingletonToApplicationScopedTestBuildChainCustomizerProducer` has to: - look for the `@Produces` annotation in ArC's `AnnotationStore`, not in Jandex; - run _after_ the annotation transformer in `AutoProducerMethodsProcessor`. This is enough to recognize an auto-producer (producer without `@Produces`). (cherry picked from commit 5aebe5a)
…onfigured (cherry picked from commit 4d591f0)
…AV on the command line (cherry picked from commit c2f36d0)
…readExecutor (cherry picked from commit 1ea93cc)
(cherry picked from commit 37834cb)
quarkus-bot
bot
added
area/arc
This comment has been minimized.
This comment has been minimized.
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
|
I see that we start having failures like: @famod @xstefank does it look like the other issue we have? /cc @mkouba |
|
@gsmet yes, very occasionally the CDI context doesn't propagate to health check invocation. |
…yment modules - Now it's back to the previous behavior (pulling in deployment modules declared as dependencies of other deployment modules) - Gradle extension plugin now verifies that all required deployment modules are specified in dependencies - Added integration test to make sure such transitive dependencies are resolved correctly (especially regarding exclusions) - Clarified documentation about validation of extensions (cherry picked from commit 62483ed)
(cherry picked from commit 5236c49)
(cherry picked from commit b8bdad1)
(cherry picked from commit 6dcfaca)
quarkus-bot
bot
added
area/dependencies
This comment has been minimized.
This comment has been minimized.
(cherry picked from commit 0f6ffef)
(cherry picked from commit ff84d5d)
Fixes quarkusio#38889 (cherry picked from commit 1921c45)
When the SmallRye Health route handler activates request context on its own, it also needs to terminate it. However, that termination needs to happen only after all health checks complete. That's what this commit does. (cherry picked from commit 650ec93)
`ValidationSchema` is annotated with `@JsonDeserialize` which leads in its entire type hierarchy being registered for reflective access along with the corresponding methods. This essentially ends up registering all models as in kubernetes-client 6.9.0 ValidationSchema was augmented to implement `Editable<ValidationSchemaBuilder>`, which increases the reachable types in comparison to previous versions. Ignoring registrations for `ValidationSchema` aligns with what we already do for `KubeSchema`. Fixes quarkusio#38683 (cherry picked from commit 637ebea)
(cherry picked from commit a6f36e1)
gsmet
force-pushed
the
3.7.4-backports-1
branch
from
25db540 to
4611ba6
Compare
Status for workflow
|
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✔️ | JVM Tests - JDK 17 | Logs | Raw logs | 🔍 | ||
| ✖ | JVM Tests - JDK 21 | Build |
Failures | Logs | Raw logs | 🔍 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ JVM Tests - JDK 21 #
- Failing: integration-tests/virtual-threads/amqp-virtual-threads integration-tests/virtual-threads/jms-virtual-threads
📦 integration-tests/virtual-threads/amqp-virtual-threads
✖ io.quarkus.it.vthreads.amqp.VirtualThreadTest.testAlert - History - More details - Source on GitHub
java.lang.RuntimeException:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.smallrye.reactivemessaging.amqp.deployment.AmqpDevServicesProcessor#startAmqpDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=quay.io/artemiscloud/activemq-artemis-broker:1.0.25, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@47b563a1)
at io.quarkus.smallrye.reactivemessaging.amqp.deployment.AmqpDevServicesProcessor.startAmqpDevService(AmqpDevServicesProcessor.java:109)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:849)
at...
📦 integration-tests/virtual-threads/jms-virtual-threads
✖ io.quarkus.it.vthreads.jms.VirtualThreadTest.testAlert - History - More details - Source on GitHub
java.lang.RuntimeException:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.artemis.core.deployment.DevServicesArtemisProcessor#startArtemisDevService threw an exception: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=quay.io/artemiscloud/activemq-artemis-broker:1.0.25, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@5eb56ba1)
at org.testcontainers.containers.GenericContainer.getDockerImageName(GenericContainer.java:1367)
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:362)
at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:333)
at io.quarkus.artemis.core.deployment.DevServicesArtemisProcessor.lambda$startArtemis$1(DevServicesArtemisProcessor.java:252)
at java.base/java.util.Optional.o...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge, I will merge it myself.