Don't warn about @notbody use in @get methods in REST Client

Fixes: quarkusio#38798
gsmet · Feb 15, 2024 · c18c33f · c18c33f
1 parent 9d5e5b2
commit c18c33f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/...c/main/java/io/quarkus/jaxrs/client/reactive/deployment/QuarkusClientEndpointIndexer.java b/...c/main/java/io/quarkus/jaxrs/client/reactive/deployment/QuarkusClientEndpointIndexer.java
@@ -72,6 +72,11 @@ protected void logMissingJsonWarning(MethodInfo info) {
                 + "' but no JSON extension has been added. Consider adding 'quarkus-rest-client-reactive-jackson' (recommended) or 'quarkus-rest-client-reactive-jsonb'.");
     }
 
+    @Override
+    protected void warnAboutMissUsedBodyParameter(DotName httpMethod, MethodInfo methodInfo) {
+        // do nothing in the case of the client
+    }
+
     public static final class Builder extends AbstractBuilder<Builder> {
 
         private final Capabilities capabilities;

diff --git a/...processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointIndexer.java b/...processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointIndexer.java
@@ -611,8 +611,7 @@ private ResourceMethod createResourceMethod(ClassInfo currentClassInfo, ClassInf
                                         + currentMethodInfo.parameterName(i));
                     bodyParamType = paramType;
                     if (GET.equals(httpMethod) || HEAD.equals(httpMethod) || OPTIONS.equals(httpMethod)) {
-                        log.warn("Using a body parameter with " + httpMethod + " is strongly discouraged. Offending method is '"
-                                + currentMethodInfo.declaringClass().name() + "#" + currentMethodInfo + "'");
+                        warnAboutMissUsedBodyParameter(httpMethod, currentMethodInfo);
                     }
                 }
                 String elementType = parameterResult.getElementType();
@@ -778,6 +777,11 @@ private ResourceMethod createResourceMethod(ClassInfo currentClassInfo, ClassInf
         }
     }
 
+    protected void warnAboutMissUsedBodyParameter(DotName httpMethod, MethodInfo methodInfo) {
+        log.warn("Using a body parameter with " + httpMethod + " is strongly discouraged. Offending method is '"
+                + methodInfo.declaringClass().name() + "#" + methodInfo + "'");
+    }
+
     protected boolean skipParameter(Map<DotName, AnnotationInstance> anns) {
         return skipMethodParameter != null && skipMethodParameter.test(anns);
     }