Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable caching for quarkus:build and declare dependencies as inputs #37622

Merged
merged 10 commits into from
Feb 16, 2024
Prev Previous commit
Next Next commit
Revert "Enable config tracking for all ITs"
This reverts commit b3eeb7c.

In the end, it is not a very good idea to enable this for all of them.
gsmet committed Feb 15, 2024

Verified

This commit was signed with the committer’s verified signature.
gsmet Guillaume Smet
commit 471c4fc5b9fc4a2952629c614107848979ebfe04
13 changes: 13 additions & 0 deletions integration-tests/main/pom.xml
Original file line number Diff line number Diff line change
@@ -23,6 +23,9 @@

<!-- do not update this dependency, it is only used for testing -->
<webjar.jquery-ui.version>1.13.0</webjar.jquery-ui.version>

<quarkus.config-tracking.enabled>true</quarkus.config-tracking.enabled>
<quarkus.native.container-build>true</quarkus.native.container-build>
zakkak marked this conversation as resolved.
Show resolved Hide resolved
</properties>

<dependencies>
@@ -507,6 +510,16 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-maven-plugin</artifactId>
<executions>
<execution>
<id>track-prod-config-changes</id>
<phase>process-resources</phase>
<goals>
<goal>track-config-changes</goal>
</goals>
<configuration>
<dumpCurrentWhenRecordedUnavailable>true</dumpCurrentWhenRecordedUnavailable>
</configuration>
</execution>
<execution>
<goals>
<goal>build</goal>
23 changes: 8 additions & 15 deletions integration-tests/pom.xml
Original file line number Diff line number Diff line change
@@ -22,9 +22,6 @@
<quarkus.build.skip>${skipTests}</quarkus.build.skip>
<native.surefire.skip>${skipTests}</native.surefire.skip>
<enforce-test-deps-scope.skip>true</enforce-test-deps-scope.skip>

<quarkus.config-tracking.enabled>true</quarkus.config-tracking.enabled>
<quarkus.native.container-build>true</quarkus.native.container-build>
</properties>

<!-- modules are in profile test-modules -->
@@ -74,18 +71,14 @@
<artifactId>quarkus-maven-plugin</artifactId>
<version>${project.version}</version>
<executions>
<!-- Track config changes and dump dependencies
Useful as build cache inputs -->
<execution>
<id>track-config-changes</id>
<phase>process-resources</phase>
<goals>
<goal>track-config-changes</goal>
</goals>
<configuration>
<dumpCurrentWhenRecordedUnavailable>true</dumpCurrentWhenRecordedUnavailable>
</configuration>
</execution>
<execution>
<!-- for now this execution will only dump Quarkus application dependency checksums that could indicate build time classpath changes -->
<id>track-config-changes</id>
<phase>process-resources</phase>
<goals>
<goal>track-config-changes</goal>
</goals>
</execution>
</executions>
<configuration>
<noDeps>true</noDeps>