Make rest-client invocation context implement ArcInvocationContext #36123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a test to the PR @manovotn |
|
So it this ready to go? |
This comment has been minimized.
This comment has been minimized.
geoand
force-pushed
the
issue36118_2
branch
from
458933e to
f35b854
Compare
|
I rebased this so CI can hopefully pass now |
brunobat
approved these changes
Sep 26, 2023
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #36118
Introduced a copy of rest-client custom invocation context into Quarkus.
On top of that, we want this class to implement
ArcInvocationContextinstead of justInvocationContextso that it works with our own interceptors which can have the former type as a non-standard method param.