Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for @AddingSpanAttributes #36138

Closed
brunobat opened this issue Sep 25, 2023 · 1 comment · Fixed by #36271
Closed

Add support for @AddingSpanAttributes #36138

brunobat opened this issue Sep 25, 2023 · 1 comment · Fixed by #36271
Assignees
@brunobat
Labels
area/tracing kind/enhancement New feature or request
Milestone
3.5.0.CR1

Comments

@brunobat
Copy link
Contributor

brunobat commented Sep 25, 2023 •
edited
Loading

Description

We need to add support to @AddingSpanAttributes:
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/c7617dc06800c15ef5fbe729688c3fcbe2c1c0d4/instrumentation-annotations/src/main/java/io/opentelemetry/instrumentation/annotations/AddingSpanAttributes.java#L35

This will add attributes to the current span and will create no new spans.
@brunobat brunobat added the kind/enhancement New feature or request label Sep 25, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 25, 2023

/cc @radcortez (opentelemetry,tracing)

@brunobat brunobat mentioned this issue Sep 25, 2023
Closed
@brunobat brunobat self-assigned this Sep 25, 2023
@brunobat brunobat moved this from Todo to In Progress in Quarkus Roadmap/Planning Sep 25, 2023
@manovotn manovotn mentioned this issue Sep 25, 2023
Merged
@brunobat brunobat mentioned this issue Oct 3, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Quarkus Roadmap/Planning Oct 5, 2023
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brunobat brunobat

Labels
area/tracing kind/enhancement New feature or request
Projects
Quarkus Roadmap/Planning
Status: Done
Milestone
3.5.0.CR1
Development

Successfully merging a pull request may close this issue.

Support for AddingSpanAttributes brunobat/quarkus
1 participant
@brunobat