Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take OTel exporter endpoint path into account #35503

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Take OTel exporter endpoint path into account #35503

merged 1 commit into from
Aug 23, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 23, 2023

Fixes: #35501

@geoand geoand requested a review from brunobat August 23, 2023 14:37
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 23, 2023

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

@geoand geoand mentioned this pull request Aug 23, 2023
Closed
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 23, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

brunobat
brunobat approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to come up with a test for this one...
I checked out the PR, did some hacking and it seems to set the right base path.

@geoand
Copy link
Contributor Author

geoand commented Aug 23, 2023

Right, I wanted to have a test but it doesn't seem easy ...

Thanks for checking!

@geoand geoand merged commit aa5f960 into quarkusio:main Aug 23, 2023
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 23, 2023
@geoand geoand deleted the #35501 branch August 24, 2023 06:54
@gsmet gsmet modified the milestones: 3.4 - main, 3.3.1 Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobat brunobat brunobat approved these changes

Assignees
No one assigned
Labels
area/tracing kind/bugfix
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.

OpenTelemetry vertx exporter wrongly parses the endpoint
3 participants
@geoand @brunobat @gsmet