Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry vertx exporter wrongly parses the endpoint #35501

Closed
mazenkhalil opened this issue Aug 23, 2023 · 4 comments · Fixed by #35503
Closed

OpenTelemetry vertx exporter wrongly parses the endpoint #35501

mazenkhalil opened this issue Aug 23, 2023 · 4 comments · Fixed by #35503
Assignees
Labels
area/tracing kind/bug Something isn't working
Milestone

Comments

@mazenkhalil
Copy link
Contributor

Describe the bug

404 error code occur while submitting the traces to open telemetry api.

The issue is originated from io.quarkus.opentelemetry.runtime.exporter.otlp.VertxHttpExporter. The implementation extracts the host from the base uri and ignores the paths.
image

Below a screenshot from my configurations and how it ended up in the exporter.
image

Expected behavior

I expect the client to parse the endpoint properly without ignoring paths in the URL

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

Darwin Mazens-MacBook-Pro.local 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul 5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000 arm64

Output of java -version

17.0.8

GraalVM version (if different from Java)

No response

Quarkus version or git rev

3.3.0

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@mazenkhalil mazenkhalil added the kind/bug Something isn't working label Aug 23, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 23, 2023

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

@geoand geoand self-assigned this Aug 23, 2023
@geoand
Copy link
Contributor

geoand commented Aug 23, 2023

Did this work properly in Quarkus 3.2?

@geoand
Copy link
Contributor

geoand commented Aug 23, 2023

#35503 should fix the issue

@mazenkhalil
Copy link
Contributor Author

Did this work properly in Quarkus 3.2?

Not sure. I was using otlp exporter before. Now switching to cdi

geoand added a commit that referenced this issue Aug 23, 2023
Take OTel exporter endpoint path into account
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 23, 2023
@gsmet gsmet modified the milestones: 3.4 - main, 3.3.1 Aug 26, 2023
gsmet pushed a commit to gsmet/quarkus that referenced this issue Aug 26, 2023
gsmet pushed a commit to gsmet/quarkus that referenced this issue Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracing kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants