Add DevUI JsonRPC service tests for Hibernate Search #34159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/hibernate-orm
yrodiere
changed the title
This comment has been minimized.
This comment has been minimized.
|
Okay, quarkus-vertx-http-deployment depends on quarkus-vertx-http-dev-ui-tests, so... I'll try a dependency on runtime only. |
Since, it's abstract, and that's kind of important information when it comes to tests.
|
Yea. We have been talking about allowing Dev UI in the case where vertx-http is not added, but for now it needs to be there. You can maybe make it optional, then the user will have to add it ? |
|
Ok I see you added it to the dev-ui-tests module. That is ok, as that will always be used in the test scope. |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #34090, fixes the Hibernate Search part of #31970.
@phillip-kruger I had to add a dependency to
quarkus-vertx-http-deploymentinquarkus-vertx-http-dev-ui-tests, I hope it makes sense. Without that, there wouldn't be any HTTP server and thus any Dev UI.