Dev UI Testing #34090
Merged
Dev UI Testing #34090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
phillip-kruger
force-pushed
the
dev-ui-testing
branch
from
9aab9fb to
8cb021f
Compare
Signed-off-by: Phillip Kruger <[email protected]>
Signed-off-by: Phillip Kruger <[email protected]>
Signed-off-by: Phillip Kruger <[email protected]>
phillip-kruger
force-pushed
the
dev-ui-testing
branch
from
572e2b4 to
1018d93
Compare
This comment has been minimized.
This comment has been minimized.
cescoffier
approved these changes
Jun 19, 2023
phillip-kruger
added
the
triage/waiting-for-ci
Sure, will do. Those are not DevUI tests though, we can only test GRPC services from what I can see. In the old DevUIs at least some of the bugs we had were related to issues in the HTML or templates... which we won't catch here. I suppose that's the best we can do easily with these more advanced Javascript-based UIs. |
|
Ok, from what I could see the existing tests mostly test data, even though that was part of html. I'll add more tests in the future that can test html , that is where we will probably use playwright |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce a base class that can be used to test JsonRPC and Build time data calls for Dev UI.
It also:
@yrodiere - The Dev UI tests can now live in the extension (so move from integration-tests to extension). I did not move the Hibernate Search extension tests (I see the tests are skipped in the extension). Can you do the move in another PR ?