Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows receiving the channel name when using Redis Pub/Sub #33703

Merged

Conversation

cescoffier
Copy link
Member

When using Redis Pub/Sub, receiving the message channel was impossible.
This was a problem when subscribing to multiple channels or using regexp.

This commit adds methods for receiving a bi-consumer to get the channel name and payload.
When not possible (for method returning a Multi), a dedicated structure is introduced (RedisPubSubMessage).

Fix #32979

When using Redis Pub/Sub, receiving the message channel was impossible.
This was a problem when subscribing to multiple channels or using regexp.

This commit adds methods for receiving a bi-consumer to get the channel name and payload.
When not possible (for method returning a Multi), a dedicated structure is introduced (RedisPubSubMessage).
@quarkus-bot
Copy link

quarkus-bot bot commented May 30, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@cescoffier cescoffier requested a review from machi1990 May 31, 2023 06:44
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @cescoffier

@cescoffier cescoffier merged commit 81687f1 into quarkusio:main May 31, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label May 31, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone May 31, 2023
@cescoffier cescoffier deleted the allow-redis-pub-sub-to-receive-channel branch May 31, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redis kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactive Redis pubsub patterns channels can't get the real channel name .
2 participants