Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive Redis pubsub patterns channels can't get the real channel name . #32979

Closed
sailyfirm opened this issue Apr 28, 2023 · 2 comments · Fixed by #33703
Closed

Reactive Redis pubsub patterns channels can't get the real channel name . #32979

sailyfirm opened this issue Apr 28, 2023 · 2 comments · Fixed by #33703
Labels
area/redis kind/enhancement New feature or request
Milestone

Comments

@sailyfirm
Copy link

Description

When reactive redis pubsub patterns channels like : xchannel-* , I hope get the real channel name [like xchannel-1 ] when Consumer message , but now I can't get it .

ReactivePubSubCommandsImpl.AbstractRedisSubscriber.java

    private void handleRedisEvent(UniEmitter<? super Void> emitter, Response r) {
        if (r != null && r.size() > 0) {
            String command = r.get(0).toString();
            if ("subscribe".equalsIgnoreCase(command) || "psubscribe".equalsIgnoreCase(command)) {
                emitter.complete(null); // Subscribed
            } else if ("message".equalsIgnoreCase(command)) {
                onMessage.accept(marshaller.decode(classOfMessage, r.get(2)));
            } else if ("pmessage".equalsIgnoreCase(command)) {
                onMessage.accept(marshaller.decode(classOfMessage, r.get(3)));
            }
        }
    }

Implementation ideas

No response

@sailyfirm sailyfirm added the kind/enhancement New feature or request label Apr 28, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 28, 2023

/cc @cescoffier (redis), @gsmet (redis), @machi1990 (redis)

@cescoffier
Copy link
Member

I need to check the protocol so see if we have the data. Also it would require introducing an envelope type carrying that info in addition to the payload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redis kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants